Add Unizen DEX #360
Merged
Add Unizen DEX #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
swansontec
approved these changes
Jan 7, 2025
src/swap/defi/unizen.ts
Outdated
|
|
||
| const UNIZEN_CONTRACTS: { | ||
| [version: string]: StringMap | ||
| } = JSON.parse(JSON.stringify(contracts)) |
There was a problem hiding this comment.
Oops! will fix before merging
| const crossChain = asMaybe(asCrossChainSwapQuote)(rawQuote) | ||
| if (crossChain != null) { | ||
| const memos: EdgeMemo[] = [] | ||
| const memoValue = crossChain[0].transactionData.memo |
There was a problem hiding this comment.
The asCrossChainSwapQuote is defined using asArray, but here we only access crossChain[0]. What if there are multiple tx's in the quote? Would the customer lose money, because the funds don't get fully swapped? I would feel safer either using asTuple to enforce a single item in the array, or somehow looping over the tx's to handle the weird case.
There was a problem hiding this comment.
It's an array of quotes and the best one is the first one. I'll change improve the cleaner name and change to asTuple to enforce it's existance
peachbits
force-pushed
the
matthew/unizen
branch
from
93e377f to
2dbba5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none