Jon/fix/uk-compliance #5319
Jon/fix/uk-compliance #5319
Conversation
…rings - We need a distinction now for a past buy/sell that already occurred, vs the verb to buy/sell. - Would incur a small cost to re-translate, but worth the organizational benefits to remove duplicates at the same time. Most of the localizations for the `TX_ACTION_LABEL_MAP` renamed keys are not translated, anyway. - Only the `buy_crypto_modal_buy_action` had translations, which were ported over for the interim while we wait for translations.
Jon-edge
force-pushed
the
jon/fix/uk-compliance
branch
2 times, most recently
from
90b8058
to
2d40ad6
Compare
src/components/Main.tsx
Outdated
|
|
||
| useAsyncEffect( | ||
| async () => { | ||
| setCountryCode(await getCountryCodeByIp()) |
There was a problem hiding this comment.
The getCountryCodeByIp function does a network call. We don't want to do a bunch of network calls as we navigate the app - it would be better to just do one call at boot-up, and then use the cached value everywhere.
We already do this with getFirstOpenInfo - if we've successfully loaded the file, it just returns the cached value instead of loading it again. We also do something similar in getDeviceSettings, but this one is actually sync rather than async, because we initialize it at boot-up.
Whether we go sync or async, I believe getCountryCodeByIp needs the same treatment to avoid a major performance regression. Also, what happens if we are in airplane mode? We might even want to cache the value between runs, maybe saving it in device settings, so we always know where we are.
There was a problem hiding this comment.
Yeah I was trying to come up with a new method to do it once somewhere and pass it around somehow without success, those are good ideas
Jon-edge
force-pushed
the
jon/fix/uk-compliance
branch
from
2d40ad6
to
0235f10
Compare
|
|
||
| if (firstOpenInfo.countryCode == null) { | ||
| // Not critical if we can't get the country code | ||
| firstOpenInfo.countryCode = await getCountryCodeByIp().catch(() => undefined) |
There was a problem hiding this comment.
Do we want to re-save here, so it's available on the next run?
There was a problem hiding this comment.
No, then they're stuck as a UK-designated device if they happened to open the app in the UK when this change goes live. Could see issues with people visiting the UK or VPN-ing.
Jon-edge
force-pushed
the
jon/fix/uk-compliance
branch
from
0235f10
to
c6816cf
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: