feat(radio,cpn): Startup splash screen and sound changes. #3451

philmoz · 2023-04-08T10:25:12Z

Fixes #3438, fixes #2537, fixes #391

Summary of changes:

Enable startup splash screen duration for color LCD radios.
Add option to disable startup sound on all radios.
Add Companion support for above changes.
Move mixer task startup to after splash screen is done on color LCD radios so that the startup sound is played first.

Notes:

The startup splash screen cannot be disabled for color LCD radios. The minimum setting is 1 second. This is because the radio.yml file has not been loaded when the splash screen is displayed so the property to disable it is unknown.
There is an initial delay on color LCD radios before the startup sound is played. This is due to the initialisation of the theme and loading the radio & model files from the SD card. The length of the delay will depend on the radio, SD card speed, theme background image and number of model files, and this delay will determine the actual minimum time for the splash screen to be shown.
Moving the mixer task startup does not seem to have caused any adverse side effects on my QX7S, TX16S Mk2 or the simulator. It probably needs more testing on other radios though.

pfeerick · 2023-04-08T10:28:29Z

Hm, be interesting to see if this fixes #135 also

philmoz · 2023-04-08T12:39:14Z

Hm, be interesting to see if this fixes #135 also

I think it should fix most cases; but it's a hard one to test.

I tested a simple widget and calling playSound in the refresh method is ok, the sound plays after the welcome sound.
Calling playSound from the create method will, however, still play before the welcome sound because Lua scripts are initialised first.

pfeerick · 2023-04-09T01:11:01Z

It's should actually to test this particular case - the yappu telemetry widget plays a "yappu telemetry ready" sound as it starts, so if that no longer precedes the ETX hello.wav when the active model on power on has the widget installed, it's fixed. I guess it will depend on where the yappu playsound is.

philmoz · 2023-04-09T01:51:04Z

I guess it will depend on where the yappu playsound is.

Yaapu plays its startup sound in the create function so this change does specifically fix #135

Added translation for PR EdgeTX#3451: #define TR_PLAY_HELLO "Startljud"

ulfhedlund · 2023-04-10T15:38:51Z

Is there a string for translation of "Play Startup Sound" in Companion?

pfeerick · 2023-07-16T05:01:33Z

Pat6874 · 2023-07-16T05:04:39Z

FR: #define TR_PLAY_HELLO "Son de démarrage"

ulfhedlund · 2023-07-16T05:49:29Z

SE:#define TR_PLAY_HELLO "Startljud"

offer-shmuely · 2023-07-16T06:28:20Z

HE
#define TR_PLAY_HELLO "צליל אתחול"

froqstar · 2023-07-16T06:40:43Z

DE:
#define TR_PLAY_HELLO "Startton"

HThuren · 2023-07-16T07:44:13Z

DA
#define TR_PLAY_HELLO "Startop lyd"

... and nice weekend to you too

zyren · 2023-07-16T08:50:22Z

CN

#define TR_PLAY_HELLO "开机语音"

TW

#define TR_PLAY_HELLO "開機語音"

Eldenroot · 2023-07-16T10:46:13Z

CZ

#define TR_PLAY_HELLO "Zvuk při spuštění"

zandorsp · 2023-07-16T11:12:04Z

PT

#define TR_PLAY_HELLO "Som ao ligar"

philmoz · 2023-07-28T11:29:07Z

The only issue (and it's a doozie...) set the startup time to 8s (or longer), and restart the radio 🤭 My TX16S at least doesn't like that...

Ooops. Any ideas?

philmoz · 2023-07-28T11:45:59Z

Suspending the watchdog timer seems to fix it - hopefully this is the correct way to do it.

pfeerick · 2023-07-28T11:49:46Z

Interesting... it fitted the timeline of the watchdog, but I had thought RTOS_WAIT_TICKS would have satisfied it... 🤷

@raphaelcoeffic @gagarinlg Your thoughts?

radio/src/opentx.h

gagarinlg · 2023-07-28T12:07:23Z

Interesting... it fitted the timeline of the watchdog, but I had thought RTOS_WAIT_TICKS would have satisfied it... 🤷

@raphaelcoeffic @gagarinlg Your thoughts?

Do not stop the watchdog!

philmoz · 2023-07-28T12:12:48Z

Do not stop the watchdog!

watchdogSuspend() is used elsewhere - is it not safe to use while the splash screen is being shown?

gagarinlg · 2023-07-28T12:20:28Z

Do not stop the watchdog!

watchdogSuspend() is used elsewhere - is it not safe to use while the splash screen is being shown?

Then we should redesign those parts.
I would prefer to regularly wake up, kick the watchdog and the go back to sleep, when the timeout is not reached

philmoz · 2023-07-28T20:50:53Z

I've changed the splash timeout loop to use WDG_RESET instead.

Add option to disable startup sound. Add Companion support for changes.

…cted.

PR #3451 introduced a change that caused the mixer task to be started out of the UI task, which introduces a race condition `mixerTaskId.rtos_handle`, as the mixer scheduler might trigger before `xTaskCreateStatic` returns and the task handle is assigned. This PR fixes the issue by delaying the start of the mixer scheduler until `xTaskCreateStatic` returned and the task handler has been properly assigned.

PR #3451 moved the start of the mixer task to a point in time where the task scheduler is already started (UI task). Before that change, the mixer task would be created before and effectively started after the task scheduler started. This introduces a race condition on `mixerTaskId.rtos_handle`, as the mixer scheduler might trigger before `xTaskCreateStatic()` returns and the task handle is assigned. This PR fixes the issue by delaying the start of the mixer scheduler until `xTaskCreateStatic()` returned and the task handler has been properly assigned.

philmoz mentioned this pull request Apr 8, 2023

Splash screen and welcome audio #3438

Closed

1 task

pfeerick added this to the 2.10 milestone Apr 8, 2023

pfeerick added bug 🪲 Something isn't working enhancement ✨ New feature or request color Related generally to color LCD radios labels Apr 8, 2023

ulfhedlund added a commit to ulfhedlund/edgetx that referenced this pull request Apr 10, 2023

Added translation for PR EdgeTX#3451

2732b96

Added translation for PR EdgeTX#3451: #define TR_PLAY_HELLO "Startljud"

ulfhedlund mentioned this pull request Apr 10, 2023

Updated se translations #3456

Closed

philmoz force-pushed the start-splash-and-sound branch from 827e35c to 37a22f7 Compare April 29, 2023 22:58

philmoz force-pushed the start-splash-and-sound branch 2 times, most recently from afc8914 to 74cb2ce Compare May 14, 2023 07:19

philmoz force-pushed the start-splash-and-sound branch from e2ffa60 to 670a112 Compare May 22, 2023 10:55

philmoz force-pushed the start-splash-and-sound branch from 670a112 to a38e277 Compare May 31, 2023 07:42

philmoz force-pushed the start-splash-and-sound branch from a38e277 to 3ae9ea7 Compare June 10, 2023 02:41

philmoz force-pushed the start-splash-and-sound branch from 3ae9ea7 to 3a8c51b Compare June 28, 2023 00:13

philmoz changed the title ~~feat(radio,cpn) - Startup splash screen and sound changes.~~ feat(radio,cpn): Startup splash screen and sound changes. Jul 5, 2023

pfeerick force-pushed the start-splash-and-sound branch from 3a8c51b to bdd6659 Compare July 16, 2023 04:57

pfeerick reviewed Jul 28, 2023

View reviewed changes

radio/src/opentx.h Outdated Show resolved Hide resolved

Phil Mitchell and others added 14 commits July 30, 2023 11:55

Enable startup splash screen duration for color LCD radios.

5b44c3f

Add option to disable startup sound. Add Companion support for changes.

Add translation string for Hebrew language file.

c684ab9

Fix rebase.

d6306c8

chore: Add T20

acd6441

Update translations.

c4553ab

Update translations.

73411e3

Update translations.

353cf3e

Update translations.

dd78a16

Right justify radio setup controls.

2d73d26

Use longer translations for all radios.

0544532

Enable splash screen timeout for NV14/EL18.

71e7058

Suspend watchdog timer to prevent EM if long splash display time sele…

266a055

…cted.

Simplify SPLASH_TIMEOUT code.

832d778

Use WDG_RESET instead of watchdogSuspend.

b4c3a14

pfeerick force-pushed the start-splash-and-sound branch from 022c8fb to b4c3a14 Compare July 30, 2023 01:56

pfeerick merged commit 9e7a331 into EdgeTX:main Jul 30, 2023
23 checks passed

raphaelcoeffic mentioned this pull request Aug 7, 2023

fix: race condition on mixer task handle #3914

Merged

philmoz deleted the start-splash-and-sound branch October 31, 2023 10:46

pfeerick mentioned this pull request Nov 4, 2023

Power on / Splash screen delay options #237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(radio,cpn): Startup splash screen and sound changes. #3451

feat(radio,cpn): Startup splash screen and sound changes. #3451

philmoz commented Apr 8, 2023 •

edited by pfeerick

Loading

pfeerick commented Apr 8, 2023

philmoz commented Apr 8, 2023

pfeerick commented Apr 9, 2023

philmoz commented Apr 9, 2023

ulfhedlund commented Apr 10, 2023

pfeerick commented Jul 16, 2023 •

edited by philmoz

Loading

Pat6874 commented Jul 16, 2023 via email •

edited by pfeerick

Loading

ulfhedlund commented Jul 16, 2023 via email •

edited by pfeerick

Loading

offer-shmuely commented Jul 16, 2023 •

edited

Loading

froqstar commented Jul 16, 2023

HThuren commented Jul 16, 2023

zyren commented Jul 16, 2023

Eldenroot commented Jul 16, 2023

zandorsp commented Jul 16, 2023

philmoz commented Jul 28, 2023

philmoz commented Jul 28, 2023

pfeerick commented Jul 28, 2023

gagarinlg commented Jul 28, 2023

philmoz commented Jul 28, 2023

gagarinlg commented Jul 28, 2023

philmoz commented Jul 28, 2023

feat(radio,cpn): Startup splash screen and sound changes. #3451

feat(radio,cpn): Startup splash screen and sound changes. #3451

Conversation

philmoz commented Apr 8, 2023 • edited by pfeerick Loading

pfeerick commented Apr 8, 2023

philmoz commented Apr 8, 2023

pfeerick commented Apr 9, 2023

philmoz commented Apr 9, 2023

ulfhedlund commented Apr 10, 2023

pfeerick commented Jul 16, 2023 • edited by philmoz Loading

Pat6874 commented Jul 16, 2023 via email • edited by pfeerick Loading

ulfhedlund commented Jul 16, 2023 via email • edited by pfeerick Loading

offer-shmuely commented Jul 16, 2023 • edited Loading

froqstar commented Jul 16, 2023

HThuren commented Jul 16, 2023

zyren commented Jul 16, 2023

Eldenroot commented Jul 16, 2023

zandorsp commented Jul 16, 2023

philmoz commented Jul 28, 2023

philmoz commented Jul 28, 2023

pfeerick commented Jul 28, 2023

gagarinlg commented Jul 28, 2023

philmoz commented Jul 28, 2023

gagarinlg commented Jul 28, 2023

philmoz commented Jul 28, 2023

philmoz commented Apr 8, 2023 •

edited by pfeerick

Loading

pfeerick commented Jul 16, 2023 •

edited by philmoz

Loading

Pat6874 commented Jul 16, 2023 via email •

edited by pfeerick

Loading

ulfhedlund commented Jul 16, 2023 via email •

edited by pfeerick

Loading

offer-shmuely commented Jul 16, 2023 •

edited

Loading