-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RGB leds supports #3909
feat: RGB leds supports #3909
Conversation
6f21389
to
459242d
Compare
CZ: #define TR_SF_MOD_BIND "Modul Bind" |
@mha1 may I ask you to check if the changes in the timer / pulses drivers still work for all modules / protocols? |
@raphaelcoeffic good one. batting my pitch to a home run. I'll do some spot checks on what I think I can do . §xternal/internal MPM, external ELRS, PWM out, softserial in. That's about it I think . |
Including quick functional tests: Just looking at signals, no functional test: Hope that helps |
@mha1 should be fixed now. |
Tested on X7
|
It looks a lot like MPM's 7ms. And indeed it was on. I was fooled because there is no more GUI indication (yellow) if there is a module set. But at least consistent. No indication for internal and external modules. Set internal module to off, all good now. |
Was the highlighting Internal RF and External RF is set to other than off scraped on purpose? |
If on purpose you would see PR with rather long discussion. Most of UI behaviour that differs from 2.8 is due to some 'fixes'. |
@raphaelcoeffic alll the serial out on CPPM/SPort and (soft and hardware) serial in on SPort seems to work too |
19c430c
to
65f92e8
Compare
Of concern: anything that uses soft serial, i.e. pulse drivers |
65f92e8
to
818273a
Compare
# Conflicts: # radio/src/gui/gui_common.cpp
3d3cca3
to
6d95768
Compare
Hey, I need this one and see if it works in my PL18 branch. |
Neither X9D+2019 nor Boxer are booting with the GitHub builds for this PR. |
This would otherwise cause endless loops when active polling is used
Should be fixes now. |
TX16S, X9D+2019, X9D, Zorro: All connected to pre-bound/bound as necessary RXs with internal MPM/ISRM/XJT, telemetry and control link good. Mix of Ghost, CRSF, Tracer, XJT/XJTLite and MPM external modules used across all the radios with no issues with github builds. |
Summary of Changes:
stm32_pulse_driver
modified to initialise DMA only once during init