feat(sim): hat switches support for NV14 and EL18

[elecpower]

Summary of changes:

• new graphics
• hats
• needs to work in conjunction with feat(el18): Use trim hats as keys for navigation #3894

To do:

• graphics for hat and direction clicks
• clickable areas overlaying graphics
• keys associated with clicks

[pfeerick]

@elecpower Where were things at with this PR? Was it just making the key events work properly now? Is there anything I can do to help with that now? I have the the handsets as well as some idea of how the hat switching functionality worked...

[elecpower]

@pfeerick it's been some time so I'll have to get back up to speed, likely tomorrow.

[pfeerick]

Thanks. No rush ;)

[elecpower]

The hat direction buttons appear to work. Key mapping validation and testing seems to be the missing piece. I think I just did a best guess.
Also ADC refactor has come along and so some more changes to key mappings likely necessary.
If you could test and let's see what else needs fixing.

[elecpower]

This may have short life if generic works sooner rather than later

[pfeerick]

lol... I think so... I was going to ask how did you want to proceed with this... i.e. finish and get it in or just implement it in generic form...

[elecpower]

If it is ready I'd merge so the sim can be tested.

[pfeerick]

Ok, I'll check it tonight, let you know what is/isn't working and we can re-evaluate from there ;)

[pfeerick]

Ok, state at present is this... all good except two buttons not doing anything... not sure why though. I moved some buttons around though (as in the keys that trigger them), and also gave the EL18 same treatment... If nothing obvious stands out, I think it's worth merging/near enough for now until it can be resolved.

Left side:
Up     = OK, RADIO SETTINGS
Down   = OK, SCREEN SETTINGS
Right  = OK, MODEL SETTINGS
Left   = NONE
Press  = OK, RTN

Right side:
Up     = NAK, not incrementing/moving up
Down   = NAK, not decrementing/moving down
Right  = OK, NEXT PAGE
Left   = OK, PREV PAGE
Press  = OK, ENTER

[JimB40]

Left side:
Up = OK, RADIO SETTINGS
Down = OK, SCREEN SETTINGS
Left = OK, MODEL SETTINGS
Right = NONE
Press = OK, RTN

Right side:
Up = NAK, not incrementing/moving up
Down = NAK, not decrementing/moving down
Left = OK, NEXT PAGE
Right = OK, PREV PAGE
Press = OK, ENTER

Is that for Simulator in Companion?
Key bindings to hats movement are somehow different than in firmware :)
MDL is LeftHat Right
PAGE> is RightHat Right
PAGE< is RightHat Left

[pfeerick]

No, I simply have left and right swapped. Companion simulator matches hardware, except for non-functional up-down on right side.

…

On Wed, 21 Aug 2024, 5:58 am Robert, ***@***.***> wrote: Left side: Up = OK, RADIO SETTINGS Down = OK, SCREEN SETTINGS Left = OK, MODEL SETTINGS Right = NONE Press = OK, RTN Right side: Up = NAK, not incrementing/moving up Down = NAK, not decrementing/moving down Left = OK, NEXT PAGE Right = OK, PREV PAGE Press = OK, ENTER Is that for Simulator in Companion? Key bindings to hats movement are somehow different than in firmware :) MDL is LeftHat Right PAGE> is RightHat Right PAGE< is RightHat Left — Reply to this email directly, view it on GitHub <#3932 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KLRQRTSI7UCIXO55CLZSONXZAVCNFSM6AAAAAA3OSP3UKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJZGY3DAMBTGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

[pfeerick]

Given I think #3932 (comment) is related to some work needed in simulator layer for to support NV14/EL18 (and probably PL18/PL18EV also), rather than a bug in this PR, I'm going to merge this sooner rather than later so it is in place for when simulators get further UI rework.

[philmoz]

Appears to be missing right side Up / Down navigation:

[pfeerick]

Correct. As per the comment referenced above.