fix: better iteration through mixers on display #3999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelcoeffic
force-pushed
the
fix-3367
branch
from
ca7e473
to
dd6c8c1
Compare
|
@philmoz may I kindly ask you for your opinion on this? |
raphaelcoeffic
force-pushed
the
fix-3367
branch
from
dd6c8c1
to
46a036e
Compare
raphaelcoeffic
changed the title
|
I tried this on X9D+2019, TX16 and LR3Pro... everything seemed to work fine when copying, deleting and moving lines. I fed the LR3 a couple of mangled models and it finally ignored the invalid lines and showed the missing ones. Leading to an interesting experience for particular model that had like 20 copies of SD and SB on a mixer line 😮 |
pfeerick
pushed a commit
that referenced
this pull request
Sep 24, 2023
…lid sources (#4008) * fix: mixer lines with empty source Backport of #3999, fixes #3367 for 2.9 * Fix color mixes display. # Conflicts: # radio/src/gui/colorlcd/model_mixes.cpp --------- Co-authored-by: Phil Mitchell <[email protected]>
Archeology! Yeah! 👑 |
gagarinlg
pushed a commit
that referenced
this pull request
Sep 27, 2023
…lid sources (#3999) * fix: mixer lines with empty source Fixes #3367 * Fix color mixes display. --------- Co-authored-by: Phil Mitchell <[email protected]>
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3367.