Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: splash screen on TProV2 #4017

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix: splash screen on TProV2 #4017

merged 2 commits into from
Sep 29, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Sep 6, 2023

Fixes splash not drawn even if requested for TPro V2 (and possibly others)

@3djc 3djc marked this pull request as draft September 6, 2023 18:43
@3djc 3djc changed the title fix: do not consider customisable switches as part of inactivity fix: splash screen on TProV2 Sep 8, 2023
@3djc 3djc marked this pull request as ready for review September 8, 2023 11:35
@philmoz
Copy link
Collaborator

philmoz commented Sep 9, 2023

This is needed on my X7S as well otherwise the splash screen randomly closes before the timeout expires.

@pfeerick
Copy link
Member

@3djc The PR works as intially described - i.e. "do not consider customisable switches as part of inactivity" ... but I'm curious as to the reasoning for that... why should the function switches be considered differently to any other switch in this regard?

@philmoz Was it truly random, or because of a switch/key/gimbal (i.e. activity) input, in which case the splash screen was apparently supposed to be skipped on B&W (whereas on colorlcd it is now skippable via a hard key press).

@pfeerick pfeerick added this to the 2.10 milestone Sep 23, 2023
@philmoz
Copy link
Collaborator

philmoz commented Sep 23, 2023

It was definitely random - the loops summing the analog and switch values were processing non-existent entries.

@3djc
Copy link
Collaborator Author

3djc commented Sep 23, 2023

And because customisable switches can (and likely will) be changed during model load

@raphaelcoeffic raphaelcoeffic merged commit 1ca220b into main Sep 29, 2023
37 checks passed
@raphaelcoeffic raphaelcoeffic deleted the 3djc/fix-tprov2-splash branch September 29, 2023 08:22
@pfeerick pfeerick added the bug 🪲 Something isn't working label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants