feat: linker support for firmware in external flash #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelcoeffic
changed the title
raphaelcoeffic
force-pushed
the
fw-ext-flash
branch
3 times, most recently
from
16062b5
to
3360675
Compare
|
TX16, TX12, TX12MK2, X9D+, EL18 and T20 all booting into bootloader and main app normally with DFU flash. Er... but writing firmware (admittedly older 2.9/2.10 builds) using bootloader on TX12/TX12MK2 and T20 results in main app not booting... 🤯 TX16S was fine (I stopped after 4 radios). |
|
Ok. there is indeed a serious issue, trying to narrow it down (it does also affect colorlcd) |
raphaelcoeffic
force-pushed
the
fw-ext-flash
branch
from
3360675
to
49a26bb
Compare
raphaelcoeffic
force-pushed
the
fw-ext-flash
branch
from
49a26bb
to
744bbc6
Compare
|
Tested OK, on BW and Colorlcd, with firmware generated using that PR, 2.11 and 2.10 branches |
|
@pfeerick we should be good now, there was an issue with how the sector address was computed. |
|
LGTM here also... TX16S, T20 and X9D+ all booting happily after DFU flash + flash via bootloader. Thank you both! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for a number of new targets (mostly H7 based) that need a more flexible linker layout. It also adds some compatibility to the flash driver for new MCUs.
Summary of changes: