Bazga merge #172
Merged
Bazga merge #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bwbohl
commented
Jan 21, 2022
bwbohl
commented
- adds Docker based automatic build on pullrequests
- mardown improvement in README
- introduces index.xql with CSS injection options
- adds no-break spaces to lang file de
- adds missing lang keys to en
- only show priority and category label in annotation meta if at least one value is present
- adds localization of categories and priorities
-
- fixes annotation previews
- adds XQDoc to annotation.xqm and edition.xqm
-
- introduces source:isSource function
- adds annotationIcons to openseadragonView
- some indentation
change headings markup to hash
Beethoven features * search for edition and work * alternatively get source labels from different xpath, but always return a string * reactivate concordance navigator all seem plausible to me
change headings markup to hash
add token replacement for app version in expath-pkg
remove suffixes from XAR name
fix to not include build/temp in xar
change headings markup to hash
Before it would fail due to the removed `mei:work/mei:titleStmt`
Before it would fail due to the removed `mei:work/mei:titleStmt`
…into feature-mei4
fix XQDoc
add MEI 4.0.1 specific isSource test
add MEI 4.0.1 specific call for getLabel
use source:isSource to determine type: source
local:getTextParticipants sourceTitle now calls source:getLable
Update getAnnotationPreviews.xql
change headings markup to hash
update XQDoc
update XQDoc
fix param-call
make variable names more comprehensive
Before it would fail due to the removed `mei:work/mei:titleStmt`
* upgrade to xquery 3.0 * use case switch differentiation whether the annotation holds a value one or more in the respective metadatum * use eutil:gelLanguageString for getting localized labels
Source meta bazga
reactivate onClick for annotations in openseadragon
Feature annot modes
fix sizes of inner annot tip elements
Update todo.css
uncomment line
Update OpenSeaDragonViewer.js
Update SourceView.js
Update getAnnotationInfos.xql
fix $annotIDLabel
to run on PR vs develp and main
|
might also close other PRs from BAZ-GA |
riedde
reviewed
Jan 21, 2022
riedde
reviewed
Jan 21, 2022
riedde
reviewed
Jan 21, 2022
|
@bwbohl There was a minor merge conflict. I resolved it. After that the checks startet, but failed. Just for your interest. |
fix typo in xqDoc
* also allow MEI 4.0.0 when retrieving mei:manifestation[@singleton] or fetching source label
|
tested locally with current EditionExample, seems to work |
|
tested locally and works with current EditionExample |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.