Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify XQuery and XQuery modules format and indentation #349

Merged
merged 114 commits into from
Feb 21, 2024
Merged

Unify XQuery and XQuery modules format and indentation #349

merged 114 commits into from
Feb 21, 2024

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Feb 5, 2024

No description provided.

DennisFriedl and others added 30 commits May 31, 2023 16:38
@DennisFriedl
Update search.xql
8efd7e0 
* an Contributing Guidelines angepasst
@DennisFriedl
Update getZone.xql
9251f51 
* Adjusted to the Contributing Guidelines
@DennisFriedl
Update getXml.xql
e15cfbe 
Adjusted to the Contributing Guidelines
@bwbohl
fix syntax: getReducedDocument.xql
3adb97a 
* add missing parenthesis
@bwbohl
fix position of variable declarations
2ba2451
@bwbohl
format and indent xql-files
0004924
@bwbohl
add POSIX compliant file ending newline
ee5ead6
@bwbohl
format and indent
ad46d6a
@bwbohl
Update checkTextGridLogin.xql
373296d
@bwbohl
Update edirom_printPreview.xql
2090f8e
@bwbohl
Update getAnnotation.xql
8a1157e
@bwbohl
Update getAnnotation.xql
5958a20
@bwbohl
Update getAnnotationInfos.xql
9031dc7
@bwbohl
Update CONTRIBUTING.md
006f9c6
@bwbohl
Update getAnnotationMeta.xql
c211204
@bwbohl
add structuring comments
b2965ed
@bwbohl
update Copyright comment
161003f
@bwbohl
add structuring comments
a2ba68e
@bwbohl
Update getAnnotationOpenAllUris.xql
f863877
@bwbohl
Update getAnnotationParticipants.xql
1a4be36
@bwbohl
Update getAnnotationPreviews.xql
6223f3a 
add structural comments for XQuery head
@bwbohl
format and indent
ad14a72
@bwbohl
Update getAnnotationPreviews.xql
f1107b6 
format and indent
@bwbohl
Update getAnnotationPreviews.xql
c486044 
add some documentation
@bwbohl
Update getAnnotations.xql
9faeada
@bwbohl
Update getAnnotationsInRendering.xql
22053e5
@bwbohl
Update getAnnotationsInText.xql
63a844d
@bwbohl
Update getAnnotationsOnPage.xql
e84433b
@bwbohl
Update getAnnotationText.xql
662dc52
@bwbohl
Update getAudioPlayer.xql
535346c
@bwbohl bwbohl mentioned this pull request Feb 21, 2024
Closed
@bwbohl
Copy link
Member Author

bwbohl commented Feb 21, 2024

@riedde I'm sorry to press a bit but any chance you complete the review of this by the end of the week?

riedde
riedde reviewed Feb 21, 2024
View reviewed changes
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
riedde
riedde previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@riedde riedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! Please have a look at my minor comments. After that it's approved :)

add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
add/data/xql/getSummary.xql Outdated Show resolved Hide resolved
bwbohl and others added 10 commits February 21, 2024 10:23
@bwbohl @riedde
Update add/data/xql/getSummary.xql
3c75f8e 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
8d37206 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
c3fdc72 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
c78e854 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
42a1a0f 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
f69564b 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
c40fd2c 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
bc26c52 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
dc2a07d 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl @riedde
Update add/data/xql/getSummary.xql
44b5118 
Co-authored-by: Dennis Ried <[email protected]>
@bwbohl bwbohl requested a review from riedde February 21, 2024 09:30
riedde
riedde previously approved these changes Feb 21, 2024
View reviewed changes
@bwbohl
Copy link
Member Author

bwbohl commented Feb 21, 2024

many thanks for reviewing @riedde ^^

@bwbohl bwbohl merged commit 90c3fb1 into develop Feb 21, 2024
1 check passed
@bwbohl bwbohl deleted the ftr/xquery-style-conformant branch February 21, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riedde riedde riedde left review comments

Assignees
No one assigned
Labels
None yet
Projects
Edirom Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwbohl @riedde @DennisFriedl