-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 S3 SPI #215
Open
SaschaSt75
wants to merge
63
commits into
Edzelf:master
Choose a base branch
from
baldram:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ESP32 S3 SPI #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library should work also with Arduino UNO or DUE board since is based on the library originally created for Arduino. As it is now ported especially for ESP boards, the target platforms list was limited.
- configure PlatformIO for easier dependency management, - use ArduinoLog logging framework, - update example, - update documentation.
It will be changed in the future after testing other variants
It should make it clear that this is an Arduino Framework library
add esp32 to architectures
Fix import method to tell preprocessor to look in the same directory
Fix include method for sound file
Update documentation with PlatformIO related information
Update library version
Reword the description for cleaner understanding
* Remove unused ArduinoLog dependency from platformio.ini * Add standard logging to the example * Clean up examples
* Remove unused dependency from Platformio's library.json * Bump version for the next release
A simple stream handler to play web radio stations using ESP8266
The previous version value caused the Arduino IDE to display warnings: Invalid version found: 1.0.9a This warning can be especially confusing for users since the Arduino IDE doesn't say which library is the source of the problem. Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-format
As Arduino IDE requires version number which is SemVer compliant, it was changed according to specification below: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#libraryproperties-file-format https://semver.org/
Remove the cache which causes an issue in some use scenarios
The sound used by the example sketch has been replaced with a shorter one.
Add description to clarify that recording is not supported.
(#42) * Add support for check and reset decoding time by SCI_DECODE_TIME Implemented handling for SCI_DECODE_TIME register according to VS1053b Datasheet specification (v1.20). When decoding correct data, current decoded time is shown in this register in full seconds. Extended API with two methods. One provides estimation of decoding time using SCI_DECODE_TIME. The other one allows to clear the value of mentioned register. Update documentation and bumped version for release.
Set the buffer to "64" instead of "32". At 32 and 128 the sound was brassy.
Enhancement for adjusting the left and right volume balance. by: fabitom
Make `write_register` public. This makes it more easy to load the patches from http://www.vlsi.fi/en/support/software/vs10xxpatches.html A discussion on further steps on support for "loading patches" opened here: #66
Aligned to the `Edzelf/Esp-radio` parent project. Added the `adjustRate` method, which was probably missing at the forking time.
Adding an extension by @CelliesProjects for dealing with vs1053 Firmware patches (binary patch files that can easily be loaded to the memory of VS10XX by a microcontroller to fix known firmware bugs): * enable a possibility for using patches/plugins, * load a default patch, * include the latest available patches from http://www.vlsi.fi/en/support/software/vs10xxpatches.html * update example code and documentation, * adjust a functionality for low-level `writeRegister`.
* Bump version
- added a support enabling stream mode and reading the chip version - adjusted documentation - fixed a problem of `.plg` extension (using a correct `.h`), which should fix a problem while loading default patches.
A fix for bug in `loadUserCode`. This seems like incompatible change, as the second argument was introduced, however the previous version is buggy and it's better to get a compilation error, and adjust a code to get rid of bug (if a new loadUserCode was already used). Please also see a discussion here: #66 (comment)
VS1053B has built-in support for I2S output, which is disabled by default and uses GPIO4-7. Adds methods to enable I2S output.
Compiling stops with the following error with compiler warnings set to `All`. `/home/cellie/Arduino/libraries/ESP_VS1053_Library/src/VS1053.cpp:298:14:error: variable 'regbuf' set but not used [-Werror=unused-but-set-variable]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
beautiful library. But I can't find the definition of VS1053_SPI. I use Arduino and an ESP32 S3. Since SPI2 is already occupied, I want to use SPI3. Where do I set this?
Greetings Sascha