This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tim-smart So the interesting thing here is that
docgen
depends onplatform
. Now, yesterday Giulio updateddocgen
and also bumped the version ofplatform
in it. However, that version was broken (missing theHttp
exports).Now, if we do not override the
@effect/platform
deps in the entire working tree with the workspace versionsdocgen
will breaks when trying to resolve the@effect/platform/Http/*
entrypoints while parsing the documentation of the package.This seems like there's a problem in how docgen resolves packages because it should really resolve them from the package it is scanning and not from itself. Anyways ... This fixes it. But it might break in the future if there are breaking changes in
platform
anddocgen
hasn't been updated with those yet because now we forcedocgen
to use our workspace modules.