Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Re-add http module #251

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Re-add http module #251

merged 1 commit into from
Nov 10, 2023

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Nov 10, 2023

@tim-smart So the interesting thing here is that docgen depends on platform. Now, yesterday Giulio updated docgen and also bumped the version of platform in it. However, that version was broken (missing the Http exports).

Now, if we do not override the @effect/platform deps in the entire working tree with the workspace versions docgen will breaks when trying to resolve the @effect/platform/Http/* entrypoints while parsing the documentation of the package.

This seems like there's a problem in how docgen resolves packages because it should really resolve them from the package it is scanning and not from itself. Anyways ... This fixes it. But it might break in the future if there are breaking changes in platform and docgen hasn't been updated with those yet because now we force docgen to use our workspace modules.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: c7d5fe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@effect/platform-browser Minor
@effect/platform-node Minor
@effect/platform-bun Minor
@effect/platform Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fubhy fubhy force-pushed the re-add-http-module branch from 9e47ca0 to da755b4 Compare November 10, 2023 14:37
@fubhy fubhy force-pushed the re-add-http-module branch from da755b4 to c7d5fe1 Compare November 10, 2023 14:42
@fubhy fubhy changed the title Re add http module Re-add http module Nov 10, 2023
@fubhy fubhy requested a review from tim-smart November 10, 2023 17:08
@IMax153 IMax153 merged commit 05fef78 into main Nov 10, 2023
3 checks passed
@IMax153 IMax153 deleted the re-add-http-module branch November 10, 2023 17:40
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants