✅ #146: Covered the telemetry by tests (#176)

Improve general coverage of the codebase:
- covered a few configs by tests
- file content expansion in configurations

pkg/api/http/config_test.go

@@ -0,0 +1,14 @@
+package http
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestHTTPConfig_DefaultConfig(t *testing.T) {
+	config := DefaultServerConfig()
+
+	require.NotNil(t, config.Address())
+	require.NotNil(t, config.ToServer())
+}

pkg/config/expander_test.go

@@ -62,3 +62,24 @@ func TestExpander_EnvVarExpanded(t *testing.T) {
 	assert.Equal(t, topP, cfg.Params[0].Value)
 	assert.Equal(t, fmt.Sprintf("$%v", budget), cfg.Params[1].Value)
 }
+
+func TestExpander_FileContentExpanded(t *testing.T) {
+	content, err := os.ReadFile(filepath.Clean(filepath.Join(".", "testdata", "expander.file.yaml")))
+	require.NoError(t, err)
+
+	expander := Expander{}
+	updatedContent := string(expander.Expand(content))
+
+	require.NotContains(t, updatedContent, "${file:")
+	require.Contains(t, updatedContent, "sk-fakeapi-token")
+}
+
+func TestExpander_FileDoesntExist(t *testing.T) {
+	content, err := os.ReadFile(filepath.Clean(filepath.Join(".", "testdata", "expander.file.notfound.yaml")))
+	require.NoError(t, err)
+
+	expander := Expander{}
+	updatedContent := string(expander.Expand(content))
+
+	require.NotContains(t, updatedContent, "${file:")
+}

pkg/config/testdata/expander.file.notfound.yaml

@@ -0,0 +1,6 @@
+name: "OpenAI"
+api_key: "${file:./testdata/doesntexist}"
+
+params:
+  - name: budget
+    value: "$$${file:./testdata/doesntexist}"

pkg/config/testdata/expander.file.yaml

@@ -0,0 +1,6 @@
+name: "OpenAI"
+api_key: "${file:./testdata/openai_key}"
+
+params:
+  - name: budget
+    value: "$$${file:./testdata/openai_key}"

pkg/config/testdata/openai_key

@@ -0,0 +1 @@
+sk-fakeapi-token

pkg/routers/retry/config_test.go

@@ -0,0 +1,13 @@
+package retry
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestRetryConfig_DefaultConfig(t *testing.T) {
+	config := DefaultExpRetryConfig()
+
+	require.NotNil(t, config)
+}

pkg/routers/router.go

@@ -194,7 +194,10 @@ func (r *LangRouter) ChatStream(
 
 		// no providers were available to handle the request,
 		//  so we have to wait a bit with a hope there is some available next time
-		r.tel.L().Warn("No healthy model found to serve streaming chat request, wait and retry", zap.String("routerID", r.ID()))
+		r.tel.L().Warn(
+			"No healthy model found to serve streaming chat request, wait and retry",
+			zap.String("routerID", r.ID()),
+		)
 
 		err := retryIterator.WaitNext(ctx)
 		if err != nil {

pkg/telemetry/logging_test.go

@@ -0,0 +1,27 @@
+package telemetry
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestLogging_PlainOutputSetup(t *testing.T) {
+	config := LogConfig{
+		Encoding: "console",
+	}
+	zapConfig := config.ToZapConfig()
+
+	require.Equal(t, "console", config.Encoding)
+	require.NotNil(t, zapConfig)
+	require.Equal(t, "console", zapConfig.Encoding)
+}
+
+func TestLogging_JSONOutputSetup(t *testing.T) {
+	config := DefaultLogConfig()
+	zapConfig := config.ToZapConfig()
+
+	require.Equal(t, "json", config.Encoding)
+	require.NotNil(t, zapConfig)
+	require.Equal(t, "json", zapConfig.Encoding)
+}

pkg/telemetry/telemetry_test.go

@@ -0,0 +1,12 @@
+package telemetry
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestTelemetry_Creation(t *testing.T) {
+	_, err := NewTelemetry(DefaultConfig())
+	require.NoError(t, err)
+}