Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 #240 Adds support for Air live reloading #270

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

ppmdo
Copy link
Contributor

@ppmdo ppmdo commented Jun 12, 2024

Adds a basic .air.toml file to support using Air for live reloading

Fixes #240

@roma-glushko
Copy link
Member

Do we need any modifications to Makefile? 👀

@roma-glushko roma-glushko added the type:enhancement New feature or request label Jun 13, 2024
@ppmdo
Copy link
Contributor Author

ppmdo commented Jun 16, 2024

True!

Just modified the Makefile to use air for "make run". Would it also make sense to include a command for installing air or something like that? If air is not installed, the command will fail.

@roma-glushko
Copy link
Member

roma-glushko commented Jun 19, 2024

@ppmdo Thank you Pablo!

Is air something we can install via go install command? If yes, we can simply add it to this command above:
https://github.com/EinStack/glide/pull/270/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R16-R21

Other then that, really eager to test this 🚀

@roma-glushko roma-glushko changed the title Adds support for Air live reloading 🔧 Adds support for Air live reloading Jun 23, 2024
@roma-glushko roma-glushko merged commit 08ee414 into EinStack:develop Jun 23, 2024
6 checks passed
@roma-glushko roma-glushko changed the title 🔧 Adds support for Air live reloading 🔧 #240 Adds support for Air live reloading Jun 23, 2024
@roma-glushko
Copy link
Member

#277 - this is what I was talking about in the last comment 👀

roma-glushko added a commit that referenced this pull request Jun 24, 2024
The first major update with breaking changes to the language chat schemas 
and begging of work on instrumenting the gateway with OpenTelemetry.

### Added

- 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest)
- ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest)
-  🔧 #221 Add B3 trace propagator (#242) (@gernest)
- 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest)
- 🔧 #248 Disable span and metrics by default (#254) (@gernest)
- 🔧 #220 Instrument API server with observability signals (#255) (@gernest)
- 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu)
- 🔧 Instrument gateway process (#256) (@gernest)
- 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz)

### Changed

- 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo)
- 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz)

#### Breaking Changes

- 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko)
- 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko)
- ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko)

### Fixed

- 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko)

### Security

- 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173)

### Miscellaneous

- 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko)
- 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko)
- 👷‍♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko)
- ✨ Switched to the new docs (@roma-glushko)
- 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 [DevX] Use air to implement hot-reloads of Glide API
2 participants