Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop: reordered loop_box arguments to be more standard #175

Closed
wants to merge 1 commit into from

Conversation

SamuelCupp
Copy link
Contributor

loop_box and loop_box_device both had the function argument 'f' first, while all other functions have this argument last. This changes them to match.

@eschnett
Copy link
Collaborator

@SamuelCupp PR #174 (just merged) should include your changes. Can you confirm?

@SamuelCupp
Copy link
Contributor Author

It looks like it contains all the changes in the code that is compiled. However, loop_box_boundary in loop.hxx was not reordered to have the f argument last. Similarly, loop_box_boundary_device in loop.hxx removed the f argument from the front but didn't add it to the end of the argument list. These are both currently surrounded by #if 0 logic, so they aren't compiled.

@eschnett
Copy link
Collaborator

Applied in #177.

@eschnett eschnett closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants