Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CarpetX: Redesign ENO stencils #237

Merged
merged 6 commits into from
Mar 6, 2024
Merged

CarpetX: Redesign ENO stencils #237

merged 6 commits into from
Mar 6, 2024

Conversation

eschnett
Copy link
Collaborator

@eschnett eschnett commented Oct 5, 2023

Make the ENO acceptance criterion per-group instead of per-function. Rename stencils for consistency.
Add a few more stencil orders.

@rhaas80
Copy link
Member

rhaas80 commented Jan 31, 2024

Is still something we want? If so, given the many lines changes (>1000) an explanation what changes would be nice to have to help a reviewer. Ideally, if there is a "mechanical" part to this (renaming functions via search & replace) and a "creative" part then each might be reviewed more quickly separately.

@eschnett
Copy link
Collaborator Author

I think this is something we want, I now think the previous implementation is wrong. I was waiting mostly for feedback from Swapnil to see whether this works.

Most of the changes were boilerplate, breaking the main loop over components (grid functions) into two sequential loops and combining all the decisions for each grid function.

This code definitively needs a clean-up. I recently saw a video where an experience C++ programmer stated that each function should fit into 30 lines... Almost there!

@eschnett eschnett merged commit 8149e62 into main Mar 6, 2024
16 checks passed
@eschnett eschnett deleted the eschnett/eno-stencils branch March 6, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants