Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewRadX: Prevent NewRadX from being applied at symmetry boundaries #39

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chcheng3
Copy link
Contributor

The loop_outermost_int and loop_outermost_int_device routines used in NewRadX should check for symmetry boundaries. This is so that at symmetry boundaries, the radiative boundary conditions are applied if and only if they are also adjacent to physical boundaries.

This pull request updates NewRadXX with the new loop syntax, so that symmetry information is passed into the loop from the patch data.

Related pull request for Loop: EinsteinToolkit/CarpetX#300

@chcheng3 chcheng3 requested a review from lwJi July 29, 2024 21:58
@chcheng3
Copy link
Contributor Author

The TestNewRadX test case has been updated so that it applies reflection symmetries, and I have checked that the output has the the correct behavior at symmetry boundaries. The test is now shortened to run only 30 iterations, which evolves the scalar pulse for long enough that any erroneous behavior should be caught in the test.

In response to the reviewer's comments from the corresponding CarpetX PR EinsteinToolkit/CarpetX#300 (comment), I also included CarpetX's driver.hxx by using the USES INCLUDE syntax, instead of hard-coding the path to the header file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants