Add office world #25
Merged
Add office world #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IDavGal <[email protected]>
IDavGal
force-pushed
the
igallesio/add_HQ_world
branch
from
a9fdc88
to
923a2c3
Compare
Signed-off-by: IDavGal <[email protected]>
francocipollone
requested changes
Nov 1, 2024
|
Let's try to scope this PR to have just the empty office and then we can work in a follow up PR for adding assets. |
|
@IDavGal Is there something I need to download to run this world? This is what I see when I load it, both in the container and locally:
|
Looks like the textures aren't copied here. We need to do so:
|
Signed-off-by: IDavGal <[email protected]>
|
Loaded correctly now!
|
JCarosella
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #8
Related to #24
Summary
Adds a world USD file for an office based on the work done for andino_gz. This PR serves as a kickoff for creating a more detailed world, adding assets and improving on top of the initial file.
Test it
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.