Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for compatibility #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MatrixLau
Copy link

Allow older version or newer version of Grindr work with the Hook but make no sure that would be compatitve with the functions

Copy link
Author

@MatrixLau MatrixLau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

@@ -15,7 +15,12 @@ class Hooker : IXposedHookLoadPackage {
fun toastInvalidVersionName() {
Toast.makeText(
appContext,
"This hook is for client version $TARGET_PKG_VERSION_NAME. (Current: $pkgVersionName) Hook will not be loaded.",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too long to toast, so split it

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this show the toasts one after another?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far as the result of my tests, it will show toasts one after another. But I still try to find a way to make a toast large enough to show the whole text.

@@ -50,7 +55,6 @@ class Hooker : IXposedHookLoadPackage {

if (pkgVersionName != TARGET_PKG_VERSION_NAME) {
toastInvalidVersionName()
return
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow hook newer or older version

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot allow the user to do that. There's a good reason for this: symbol obfuscation mapping varies per version, so if you try to run the hooks with the wrong version, expect undefined behavior and weird bugs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't thought about that before sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants