#1242562 [Elasticsearch] Prevent automatic ES requests during model A… #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbayet
force-pushed
the
fix-1242562-ES-requests-during-API-calls
branch
from
3e6889c
to
ca808db
Compare
botisSmile
force-pushed
the
fix-1242562-ES-requests-during-API-calls
branch
from
ca808db
to
ada18d7
Compare
|
Coverage report for commit: a85ec72 Summary - Lines: 85.12% 🔽 | Methods: 84.62% 🔽
Backend Coverage compared to target branch |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Frontend Coverage of this branch
Minimum allowed coverage is Generated by 🐒 cobertura-action against a85ec72 |
romainruaud
approved these changes
Jul 21, 2023
botisSmile
approved these changes
Jul 21, 2023
rbayet
force-pushed
the
fix-1242562-ES-requests-during-API-calls
branch
from
ada18d7
to
8e1f7ab
Compare
github-actions
bot
added
frontend
rbayet
force-pushed
the
fix-1242562-ES-requests-during-API-calls
branch
from
8e1f7ab
to
a85ec72
Compare
github-actions
bot
removed
frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PI calls
API Platform's Elasticsearch bridge data providers are enabled by default because they look for an "elasticsearch" boolean property and if it is missing, they consider to valued to "true".
This patch reverts the logic: the data providers ared used only if the property is present.