Feat 1275390 autocomplete trotinette attributs #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthias-goupil
commented
May 29, 2024
matthias-goupil
commented
| Q | A |
|---|---|
| Branch? | master for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | OSL-3.0 |
github-actions
bot
added
frontend
matthias-goupil
force-pushed
the
feat-1275390-AutocompleteTrotinetteAttributs
branch
2 times, most recently
from
f622f94
to
884e7d6
Compare
|
Coverage report for commit: 46beda6 Summary - Lines: 86.66% ⏹️ | Methods: 84.40% ⏹️
Backend Coverage compared to target branch |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Frontend Coverage of this branch
Minimum allowed coverage is Generated by 🐒 cobertura-action against 46beda6 |
botisSmile
requested changes
May 30, 2024
Comment on lines
377
to
381
| ? 'Oui' | ||
| : option.option.label} |
There was a problem hiding this comment.
replace 'Oui' by 'Yes' example app is in english
front/example-app/src/types/facet.ts
Outdated
|
|
||
| export interface IFacetAutocomplete extends Omit<IGraphqlAggregation, 'type'> { | ||
| fieldType: AggregationType | ||
| type: 'aggregation' |
There was a problem hiding this comment.
For me the type should be 'attribute' ?
Comment on lines
138
to
147
| if (aggregation.type === 'checkbox') { | ||
| aggregationOptions = aggregation.options | ||
| } else if (aggregation.type === 'boolean') { | ||
| aggregationOptions = aggregation.options.filter( | ||
| (option) => option.value === '1' | ||
| ) | ||
| } |
There was a problem hiding this comment.
a switch case is more relevant here ?
matthias-goupil
force-pushed
the
feat-1275390-AutocompleteTrotinetteAttributs
branch
2 times, most recently
from
beef66c
to
f7d452d
Compare
PierreGauthier
force-pushed
the
feat-1275390-AutocompleteTrotinetteAttributs
branch
from
f7d452d
to
46beda6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.