Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example app] Use 'in' operator in facets for date and location attributes #634

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

botisSmile
Copy link
Contributor

…or date and location attributes

Q A
Branch? master for features / current stable version branch for bug fixes
Tickets #...
License OSL-3.0

@github-actions github-actions bot added frontend PR targets frontend application example-app PR targets the frontend example app labels Oct 28, 2024
Copy link

Coverage report for commit: 7033519
File: api/coverage/coverage.xml

Summary - Lines: 87.32% | Methods: 84.62%
FilesLinesMethodsBranchs
/app/src
   Kernel.php0.00%0.00%-
/app/vendor/gally/gally-premium
   .php-cs-fixer.dist.php---
/app/vendor/gally/gally-premium/Boost/src/Decoration/Search/Elasticsearch/Builder/Request/Query
   QueryBuilder.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/DependencyInjection
   Configuration.php---
   GallyBoostExtension.php---
/app/vendor/gally/gally-premium/Boost/src/Entity
   Boost.php100.00%100.00%-
   BoostPreview.php57.14%57.14%-
/app/vendor/gally/gally-premium/Boost/src/Entity/Boost
   CategoryLimitation.php100.00%100.00%-
   RequestType.php100.00%100.00%-
   SearchLimitation.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/Migrations
   Version20230308134429_Add_Initial_Boost_Tables.php0.00%0.00%-
/app/vendor/gally/gally-premium/Boost/src/OpenApi
   BoostDecorator.php25.00%50.00%-
/app/vendor/gally/gally-premium/Boost/src/Repository/Boost
   CategoryLimitationRepository.php100.00%100.00%-
   RequestTypeRepository.php100.00%100.00%-
   SearchLimitationRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/Repository
   BoostRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/Resolver
   BoostPreviewResolver.php98.80%80.00%-
/app/vendor/gally/gally-premium/Boost/src/Service
   BoostApplier.php95.74%66.67%-
   LimitationTypeProvider.php100.00%100.00%-
   ModelProvider.php100.00%100.00%-
   QueryTextOperatorProvider.php100.00%100.00%-
   RequestTypeProvider.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/Service/Function/Provider
   DefaultProvider.php100.00%100.00%-
   Exclude.php83.33%0.00%-
   FunctionProviderInterface.php---
   Replace.php---
/app/vendor/gally/gally-premium/Boost/src/Service/Limitation
   CategoryLimitation.php100.00%100.00%-
   LimitationInterface.php---
   QueryTextLimitation.php100.00%100.00%-
/app/vendor/gally/gally-premium/Boost/src/Service/Model
   ConstantScore.php83.33%75.00%-
/app/vendor/gally/gally-premium/Boost/src/State
   BoostProcessor.php87.50%50.00%-
   BoostProvider.php93.75%66.67%-
/app/vendor/gally/gally-premium/Boost/src/State/Source
   LimitationTypeOptionProvider.php90.91%50.00%-
   ModelOptionProvider.php90.91%50.00%-
   QueryTextOperatorOptionProvider.php90.00%50.00%-
   RequestTypeOptionProvider.php90.91%50.00%-
/app/vendor/gally/gally-premium/Boost/src/Validator/ModelConfig
   ConstantScoreValidator.php100.00%100.00%-
   ModelConfigValidatorInterface.php---
/app/vendor/gally/gally-premium/Boost/src/Validator
   ModelConfigConstraint.php100.00%100.00%-
   ModelConfigConstraintValidator.php100.00%100.00%-
   ModelConstraintValidator.php100.00%100.00%-
   QueryTextOperatorConstraintValidator.php100.00%100.00%-
   RequestTypeConstraintValidator.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/Decoration/GraphQl
   AddEntityTypeInContext.php100.00%100.00%-
   AddExplainData.php100.00%100.00%-
   AddExplainType.php97.78%85.71%-
/app/vendor/gally/gally-premium/Explain/src/DependencyInjection
   Configuration.php---
   GallyExplainExtension.php---
/app/vendor/gally/gally-premium/Explain/src/Entity
   ExplainDocument.php100.00%100.00%-
   ExplainProduct.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/OpenApi
   ExplainDecorator.php25.00%50.00%-
/app/vendor/gally/gally-premium/Explain/src/Repository
   ExplainRepository.php26.83%33.33%-
/app/vendor/gally/gally-premium/Explain/src/Serializer
   ExplainProductDenormalizer.php95.83%75.00%-
/app/vendor/gally/gally-premium/Explain/src/Service/Collector
   CollectorInterface.php---
   Position.php100.00%100.00%-
   Synonym.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/Service
   ExplainConfig.php50.00%50.00%-
   RequestTypeProvider.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/Service/ExplainProduct
   DescriptionsGenerator.php100.00%100.00%-
   Highlights.php89.29%50.00%-
   SynonymManager.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/Service/Hydrator
   ExplainProductHydrator.php89.31%71.43%-
   ExplainProductHydratorFactory.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/State
   ExplainProductProvider.php98.08%75.00%-
   Paginator.php100.00%100.00%-
/app/vendor/gally/gally-premium/Explain/src/State/Source
   RequestTypeOptionProvider.php90.91%50.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Decoration/Index/Service
   IndexSettings.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Decoration/Search/Elasticsearch/Builder/Request/Query/Fulltext
   FulltextQueryBuilder.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/DependencyInjection
   Configuration.php---
   GallyThesaurusExtension.php---
/app/vendor/gally/gally-premium/Thesaurus/src/Entity
   Thesaurus.php94.38%92.86%-
/app/vendor/gally/gally-premium/Thesaurus/src/Entity/Thesaurus
   Expansion.php80.00%90.00%-
   Locale.php100.00%100.00%-
   Synonym.php76.47%87.50%-
/app/vendor/gally/gally-premium/Thesaurus/src/Entity/Thesaurus/Expansion
   Term.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Entity/Thesaurus/Synonym
   Term.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/EventSubscriber
   ReindexThesaurus.php40.00%66.67%-
   SetThesaurusIndexerContext.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Migrations
   Version20230407155058_Add_Initial_Thesaurus_Tables.php0.00%0.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Repository/Thesaurus/Expansion
   TermRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Repository/Thesaurus
   ExpansionRepository.php100.00%100.00%-
   LocaleRepository.php100.00%100.00%-
   SynonymRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Repository/Thesaurus/Synonym
   TermRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Repository
   ThesaurusRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Service
   Indexer.php100.00%100.00%-
   ThesaurusManager.php93.58%76.92%-
/app/vendor/gally/gally-premium/Thesaurus/src/Service/Indexer
   ThesaurusIndexerContext.php83.33%66.67%-
/app/vendor/gally/gally-premium/Thesaurus/src/Service/ThesaurusConfiguration
   ThesaurusConfiguration.php100.00%100.00%-
   ThesaurusConfigurationFactory.php100.00%100.00%-
   ThesaurusConfigurationInterface.php---
/app/vendor/gally/gally-premium/Thesaurus/src/State/Thesaurus
   ExpansionProcessor.php88.00%66.67%-
   SynonymProcessor.php88.00%66.67%-
/app/vendor/gally/gally-premium/Thesaurus/src/State
   ThesaurusProcessor.php96.30%75.00%-
/app/vendor/gally/gally-premium/Thesaurus/src/Validator
   ThesaurusScopeConstraint.php100.00%100.00%-
   ThesaurusScopeConstraintValidator.php100.00%100.00%-
   ThesaurusTypeConstraint.php100.00%100.00%-
   ThesaurusTypeConstraintValidator.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Command
   UploadModel.php0.00%0.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Controller
   DeployModel.php0.00%0.00%-
   UndeployModel.php0.00%0.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Decoration
   AddEmbeddingFieldInMapping.php100.00%100.00%-
   AddVectorClauseInSearchQuery.php100.00%100.00%-
   AddVectorSettingsInIndex.php70.00%57.14%-
/app/vendor/gally/gally-premium/VectorSearch/src/DependencyInjection
   Configuration.php---
   GallyVectorSearchExtension.php---
/app/vendor/gally/gally-premium/VectorSearch/src/Entity
   Model.php48.48%90.00%-
   Task.php75.00%75.00%-
   VectorConfiguration.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/EventSubscriber
   UpdatePipelineVectorSourceFieldData.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Hydrator
   VectorConfigurationHydrator.php94.12%50.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Migrations
   Version20231117151709_Add_Vector_Search_Tables.php0.00%0.00%-
   Version20231130101656_Add_Vector_Position_Prompt_Tables.php0.00%0.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/OpenApi
   DocumentDecorator.php25.00%50.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Repository/Model
   ModelRepository.php63.46%33.33%-
/app/vendor/gally/gally-premium/VectorSearch/src/Repository/Task
   TaskRepository.php90.91%50.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Repository
   VectorConfigurationRepository.php94.59%87.50%-
/app/vendor/gally/gally-premium/VectorSearch/src/SearchClient/OpenSearch/Adapter/Common/Request/Query/Assembler
   Neural.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/SearchClient/OpenSearch/Builder/Request/Query
   VectorQueryBuilder.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/SearchClient/OpenSearch/Request/Query
   Neural.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Serializer
   DocumentDenormalizer.php60.00%33.33%-
   DocumentNormalizer.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Service
   VectorPipelineProcessorProvider.php100.00%100.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/Service/VectorSearchConfiguration
   VectorSearchConfiguration.php100.00%100.00%-
   VectorSearchConfigurationFactory.php100.00%100.00%-
   VectorSearchConfigurationInterface.php---
/app/vendor/gally/gally-premium/VectorSearch/src/State
   DocumentProvider.php---
   ModelProcessor.php0.00%0.00%-
   ModelProvider.php0.00%0.00%-
/app/vendor/gally/gally-premium/VectorSearch/src/State/VectorConfiguration
   CollectionProvider.php100.00%100.00%-
   ItemProvider.php100.00%100.00%-
/app/vendor/gally/gally-premium/VirtualCategory/src/Decoration/Entity/GraphQl/Type/Definition/Filter
   CategoryTypeDefaultFilterInputType.php85.71%50.00%-
/app/vendor/gally/gally-premium/VirtualCategory/src/Decoration/Repository/CategoryProductPositionIndexer
   CategoryProductPositionIndexerRepository.php100.00%100.00%-
/app/vendor/gally/gally-premium/VirtualCategory/src/DependencyInjection
   GallyVirtualCategoryExtension.php---
/app/vendor/gally/gally-premium/VirtualCategory/src/Elasticsearch/Request/Aggregation/ConfigResolver
   CategoryAggregationConfigResolver.php100.00%100.00%-
/app/vendor/gally/gally-premium/VirtualCategory/src/EventSubscriber
   ClearRuleCache.php93.33%83.33%-
/app/vendor/gally/gally-premium/VirtualCategory/src/Service
   CategoryQueryProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard
   .php-cs-fixer.dist.php---
/app/vendor/gally/gally-standard/src/Analysis/Service
   Config.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Bundle/State
   ExtraBundleProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Cache/Command
   ClearAllCommand.php---
   ClearTagsCommand.php---
   CreateCacheObjectCommand.php---
/app/vendor/gally/gally-standard/src/Cache/EventSubscriber
   AddProxyCacheTagsSubscriber.php62.50%66.67%-
   ResponseSubscriber.php57.14%50.00%-
/app/vendor/gally/gally-standard/src/Cache/Service
   CacheManager.php70.83%50.00%-
   ProxyCacheManager.php91.67%66.67%-
/app/vendor/gally/gally-standard/src/Catalog/Entity
   Catalog.php52.94%77.78%-
   LocalizedCatalog.php90.91%92.86%-
/app/vendor/gally/gally-standard/src/Catalog/Exception
   NoCatalogException.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Catalog/Filter
   LocalizedCatalogLocaleFilter.php93.44%0.00%-
/app/vendor/gally/gally-standard/src/Catalog/Repository
   CatalogRepository.php100.00%100.00%-
   LocalizedCatalogRepository.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Catalog/Service
   DefaultCatalogProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Catalog/State
   LocalizedCatalogProcessor.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Catalog/State/Source
   LocalizedCatalogGroupOptionProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Controller
   CategoryConfigurationGet.php86.36%50.00%-
   CategoryProductPositionGet.php100.00%100.00%-
   CategoryProductPositionSave.php100.00%100.00%-
   GetCategoryTree.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Decoration
   SyncCategoryDataAfterBulk.php100.00%100.00%-
   SyncCategoryDataAfterBulkDelete.php100.00%100.00%-
   SyncCategoryDataAfterBulkDeleteRest.php100.00%100.00%-
   SyncCategoryDataAfterBulkRest.php100.00%100.00%-
   SyncCategoryDataAfterInstall.php100.00%100.00%-
   SyncCategoryDataAfterInstallRest.php92.86%50.00%-
/app/vendor/gally/gally-standard/src/Category/Entity
   Category.php100.00%100.00%-
   CategoryTree.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Entity/Category
   Configuration.php100.00%100.00%-
   ProductMerchandising.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/EventSubscriber
   ReindexPosition.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Exception
   SyncCategoryException.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/OpenApi
   CategoryDecorator.php11.11%50.00%-
/app/vendor/gally/gally-standard/src/Category/Repository
   CategoryConfigurationRepository.php100.00%100.00%-
   CategoryProductMerchandisingRepository.php100.00%100.00%-
   CategoryRepository.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Repository/CategoryProductPositionIndexer
   CategoryProductPositionIndexerRepository.php73.61%33.33%-
/app/vendor/gally/gally-standard/src/Category/Resolver
   CategoryTreeResolver.php100.00%100.00%-
   ConfigurationResolver.php94.12%50.00%-
   PositionGetResolver.php100.00%100.00%-
   PositionSaveResolver.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Category/Service
   CategoryProductPositionManager.php96.00%85.71%-
   CategorySynchronizer.php100.00%100.00%-
   CategoryTreeBuilder.php98.36%80.00%-
   CurrentCategoryProvider.php80.00%66.67%-
/app/vendor/gally/gally-standard/src/Configuration/State
   ConfigurationProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/DependencyInjection
   Configuration.php---
   Extension.php---
   GallyExtension.php---
   GenericFactory.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Doctrine/Filter
   BooleanFilter.php82.35%50.00%-
   RangeFilterWithDefault.php66.67%33.33%-
   SearchColumnsFilter.php96.77%0.00%-
   SearchFilter.php64.06%42.86%-
   SearchFilterWithDefault.php52.63%50.00%-
   VirtualSearchFilter.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Exception
   LogicException.php---
/app/vendor/gally/gally-standard/src/Fixture/Service
   ElasticsearchFixtures.php52.17%60.00%-
   EntityIndicesFixtures.php95.24%75.00%-
   ORMPsqlSequenceProvider.php33.33%50.00%-
/app/vendor/gally/gally-standard/src
   GallyBundle.php---
/app/vendor/gally/gally-standard/src/GraphQl/Decoration/Resolver/Stage
   ReadStage.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/GraphQl/Decoration/Serializer
   SerializerContextBuilder.php94.44%66.67%-
/app/vendor/gally/gally-standard/src/GraphQl/Decoration/Type
   RenameGraphQlQuery.php90.48%77.78%-
/app/vendor/gally/gally-standard/src/GraphQl/Type/Definition
   FilterInterface.php---
/app/vendor/gally/gally-standard/src/Hydra/Decoration/Serializer
   DocumentationNormalizer.php90.91%66.67%-
/app/vendor/gally/gally-standard/src/Index/Command
   IndexClearCommand.php0.00%0.00%-
   MappingGenerateCommand.php0.00%0.00%-
   MappingStatusCommand.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/Index/Controller
   RemoveIndexDocument.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Index/Converter/SourceField
   BasicSourceFieldConverter.php100.00%100.00%-
   CategorySourceFieldConverter.php100.00%100.00%-
   ImageSourceFieldConverter.php100.00%100.00%-
   LocationSourceFieldConverter.php100.00%100.00%-
   ObjectSourceFieldConverter.php50.00%50.00%-
   PriceSourceFieldConverter.php100.00%100.00%-
   ReferenceSourceFieldConverter.php100.00%100.00%-
   SelectSourceFieldConverter.php100.00%100.00%-
   StockSourceFieldConverter.php100.00%100.00%-
   TextSourceFieldConverter.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Index/Dto/Bulk
   Request.php100.00%100.00%-
   Response.php81.48%57.14%-
/app/vendor/gally/gally-standard/src/Index/Entity
   Index.php100.00%100.00%-
   IndexDocument.php66.67%60.00%-
/app/vendor/gally/gally-standard/src/Index/Entity/Index
   Mapping.php97.40%91.67%-
   SelfReindex.php83.33%80.00%-
/app/vendor/gally/gally-standard/src/Index/Entity/Index/Mapping
   Field.php93.81%86.96%-
   Status.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Index/MutationResolver
   BulkDeleteIndexMutation.php100.00%100.00%-
   BulkIndexMutation.php96.55%75.00%-
   CreateIndexMutation.php62.50%50.00%-
   InstallIndexMutation.php83.33%50.00%-
   RefreshIndexMutation.php83.33%50.00%-
   SelfReindexMutation.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Index/OpenApi
   IndexDecorator.php20.00%50.00%-
/app/vendor/gally/gally-standard/src/Index/Repository/Document
   DocumentRepository.php56.25%75.00%-
/app/vendor/gally/gally-standard/src/Index/Repository/Index
   IndexRepository.php85.05%66.67%-
/app/vendor/gally/gally-standard/src/Index/Service
   IndexOperation.php95.38%75.00%-
   IndexSettings.php90.82%73.08%-
   MetadataManager.php100.00%100.00%-
   SelfReindexOperation.php84.85%33.33%-
/app/vendor/gally/gally-standard/src/Index/State
   CreateIndexProcessor.php68.75%50.00%-
   DocumentProcessor.php100.00%100.00%-
   IndexProcessor.php75.00%50.00%-
   IndexProvider.php100.00%100.00%-
   InstallIndexProcessor.php88.89%50.00%-
   MappingStatusProvider.php100.00%100.00%-
   RefreshIndexProcessor.php87.50%50.00%-
   SelfReIndexProcessor.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Locale/EventSubscriber
   LocaleSubscriber.php76.92%66.67%-
   ResponseSubscriber.php62.50%50.00%-
/app/vendor/gally/gally-standard/src/Locale/State/Source
   LocaleGroupOptionProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Menu/Controller
   MenuController.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Menu/Entity
   Menu.php100.00%100.00%-
   MenuItem.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Menu/Resolver
   MenuResolver.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Menu/Service
   MenuBuilder.php94.12%50.00%-
/app/vendor/gally/gally-standard/src/Metadata/Constant
   SourceFieldAttributeMapping.php---
/app/vendor/gally/gally-standard/src/Metadata/Controller
   BulkSourceFieldOptions.php100.00%100.00%-
   BulkSourceFields.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/Entity/Attribute
   AttributeFactory.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/Entity/Attribute/Type
   AbstractAttribute.php100.00%100.00%-
   AbstractStructuredAttribute.php88.89%66.67%-
   BooleanAttribute.php85.71%50.00%-
   CategoryAttribute.php100.00%100.00%-
   FloatAttribute.php85.71%50.00%-
   IntAttribute.php85.71%50.00%-
   NestedAttribute.php100.00%100.00%-
   PriceAttribute.php100.00%100.00%-
   SelectAttribute.php100.00%100.00%-
   StockAttribute.php100.00%100.00%-
   TextAttribute.php88.89%50.00%-
/app/vendor/gally/gally-standard/src/Metadata/Entity/Doctrine
   QueryBuilder.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/Entity
   Metadata.php42.86%71.43%-
   SourceField.php85.71%90.48%-
   SourceFieldLabel.php100.00%100.00%-
   SourceFieldOption.php100.00%100.00%-
   SourceFieldOptionLabel.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/Entity/SourceField
   Type.php100.00%100.00%-
   Weight.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/EventSubscriber
   GenerateSourceFieldSearch.php85.19%66.67%-
   SpreadSourceFieldData.php100.00%100.00%-
   ValidateSourceFieldCode.php100.00%100.00%-
   ValidateSourceFieldProperties.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/GraphQl/Type/Definition/Filter
   AbstractFilter.php94.12%90.00%-
   BoolFilterInputType.php100.00%100.00%-
   BoolTypeFilterInputType.php100.00%100.00%-
   CategoryTypeDefaultFilterInputType.php100.00%100.00%-
   DateTypeFilterInputType.php73.02%75.00%-
   EntityFilterInterface.php---
   FloatTypeFilterInputType.php100.00%100.00%-
   IntegerTypeFilterInputType.php50.00%75.00%-
   LocationTypeFilterInputType.php43.90%80.00%-
   PriceTypeDefaultFilterInputType.php97.14%80.00%-
   SelectTypeDefaultFilterInputType.php100.00%100.00%-
   StockTypeDefaultFilterInputType.php100.00%100.00%-
   TextTypeFilterInputType.php77.78%66.67%-
/app/vendor/gally/gally-standard/src/Metadata/Operation
   Bulk.php1.23%33.33%-
/app/vendor/gally/gally-standard/src/Metadata/Repository
   MetadataRepository.php86.67%50.00%-
   SourceFieldLabelRepository.php100.00%100.00%-
   SourceFieldOptionLabelRepository.php100.00%100.00%-
   SourceFieldOptionRepository.php100.00%100.00%-
   SourceFieldRepository.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/Service
   PriceGroupProvider.php100.00%100.00%-
   ReferenceLocationProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Metadata/State
   SourceFieldOptionProcessor.php96.18%70.00%-
   SourceFieldProcessor.php96.53%80.00%-
/app/vendor/gally/gally-standard/src/Metadata/Validator
   SourceFieldDataValidator.php93.94%80.00%-
   SourceFieldOptionDataValidator.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Migrations/Version
   GallyComparator.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/Migrations
   Version20230119101706_Initial_Schema.php0.00%0.00%-
   Version20230727115502_Update_Product_Id_Type.php0.00%0.00%-
   Version20231124110343_Add_Autocomplete_Column.php0.00%0.00%-
   Version20240904155711_Add_Spannable_Column.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/OpenApi/Helper
   Documentation.php5.56%20.00%-
/app/vendor/gally/gally-standard/src/Product/Decoration/CategoryData
   SyncCategoryNameAfterBulk.php100.00%100.00%-
   SyncCategoryNameAfterBulkRest.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/Decoration/GraphQl
   AddEntityTypeInContext.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/Entity
   Product.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/GraphQl/Type/Definition
   FieldFilterInputType.php100.00%100.00%-
   ProductRequestTypeEnumType.php100.00%100.00%-
   SortInputType.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/OpenApi
   ProductDecorator.php20.00%50.00%-
/app/vendor/gally/gally-standard/src/Product/Serializer
   ProductDenormalizer.php88.37%75.00%-
/app/vendor/gally/gally-standard/src/Product/Service
   CategoryNameUpdater.php100.00%100.00%-
   ProductDefaultSortingOptionProvider.php92.86%50.00%-
   ProductsSortingOptionsProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/Service/GraphQl
   FilterManager.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Product/State/Facet
   OptionProvider.php85.71%0.00%-
/app/vendor/gally/gally-standard/src/Product/State
   ProductProvider.php98.67%83.33%-
   ProductSortingOptionProvider.php75.00%50.00%-
/app/vendor/gally/gally-standard/src/Product/Validator
   DefaultSortingFieldConstraintValidator.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/RequestContext/EventSubscriber
   AddRequestContextHeadersInVary.php66.67%66.67%-
/app/vendor/gally/gally-standard/src/RequestContext/Service
   RequestContextManager.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/ResourceMetadata/Service
   ResourceMetadataManager.php91.67%71.43%-
/app/vendor/gally/gally-standard/src/Routing/Service
   GallyLoader.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/RuleEngine/Controller
   RuleEngineGraphQlFiltersController.php77.78%50.00%-
   RuleEngineOperatorsController.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/RuleEngine/Entity
   RuleEngineGraphQlFilters.php60.00%75.00%-
   RuleEngineOperators.php81.82%87.50%-
/app/vendor/gally/gally-standard/src/RuleEngine/EventSubscriber
   ClearRuleCache.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/RuleEngine/GraphQl/Type/Definition
   RuleFilterInterface.php---
/app/vendor/gally/gally-standard/src/RuleEngine/OpenApi
   RuleEngineDecorator.php20.00%50.00%-
/app/vendor/gally/gally-standard/src/RuleEngine/Resolver
   RuleEngineGraphQlFiltersResolver.php83.33%50.00%-
   RuleEngineOperatorsResolver.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/RuleEngine/Service
   RuleEngineManager.php84.13%83.33%-
/app/vendor/gally/gally-standard/src/RuleEngine/Service/RuleType
   AbstractRuleType.php66.67%0.00%-
   AttributeRule.php98.25%90.00%-
   CombinationRule.php100.00%100.00%-
   RuleTypeInterface.php---
/app/vendor/gally/gally-standard/src/Search/Compiler
   GetContainerConfigurationFactory.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/Search/Constant
   FilterOperator.php---
/app/vendor/gally/gally-standard/src/Search/Decoration/GraphQl
   AddAggregationsData.php94.87%80.00%-
   AddAggregationsInContext.php100.00%100.00%-
   AddAggregationsType.php98.04%85.71%-
   AddSortInfoData.php100.00%100.00%-
   AddSortInfoType.php96.77%85.71%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch
   Adapter.php73.33%50.00%-
   ContextInterface.php---
   Request.php96.88%92.86%-
   RequestFactory.php100.00%100.00%-
   RequestInterface.php---
   ResponseInterface.php---
   Spellchecker.php96.67%90.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Aggregation
   Assembler.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Aggregation/Assembler/Bucket
   DateHistogram.php100.00%100.00%-
   DateRange.php100.00%100.00%-
   GeoDistance.php100.00%100.00%-
   Histogram.php100.00%100.00%-
   MultiTerms.php100.00%100.00%-
   QueryGroup.php100.00%100.00%-
   ReverseNested.php100.00%100.00%-
   SignificantTerms.php100.00%100.00%-
   Terms.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Aggregation/Assembler
   Metric.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Aggregation/Assembler/Pipeline
   BucketSelector.php100.00%100.00%-
   MaxBucket.php100.00%100.00%-
   MovingFunction.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request
   Mapper.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Query
   Assembler.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/Query/Assembler
   AbstractComplexAssembler.php100.00%100.00%-
   Boolean.php100.00%100.00%-
   Common.php100.00%100.00%-
   DateRange.php100.00%100.00%-
   Exists.php100.00%100.00%-
   Filtered.php100.00%100.00%-
   FunctionScore.php93.75%0.00%-
   GeoDistance.php100.00%100.00%-
   MatchPhrasePrefix.php100.00%100.00%-
   MatchQuery.php100.00%100.00%-
   Missing.php100.00%100.00%-
   MoreLikeThis.php100.00%100.00%-
   MultiMatch.php100.00%100.00%-
   Nested.php100.00%100.00%-
   Not.php100.00%100.00%-
   Range.php100.00%100.00%-
   SpanNear.php100.00%100.00%-
   SpanTerm.php100.00%100.00%-
   Term.php100.00%100.00%-
   Terms.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Request/SortOrder
   Assembler.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Adapter/Common/Response
   Aggregation.php100.00%100.00%-
   BucketValue.php75.00%75.00%-
   QueryResponse.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request/Aggregation
   AggregationBuilder.php94.74%75.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request/Query/Filter
   FilterQueryBuilder.php97.65%66.67%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request/Query/Fulltext
   FulltextQueryBuilder.php96.71%80.00%-
   FuzzyFieldFilter.php100.00%100.00%-
   SearchableFieldFilter.php100.00%100.00%-
   SpannableFieldFilter.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request/Query
   QueryBuilder.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request
   RequestBuilder.php0.00%0.00%-
   SimpleRequestBuilder.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Request/SortOrder
   GeoDistance.php94.12%90.00%-
   Nested.php100.00%100.00%-
   Script.php100.00%100.00%-
   SortOrderBuilder.php100.00%100.00%-
   Standard.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Builder/Response
   AggregationBuilder.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation/Bucket
   AbstractBucket.php100.00%100.00%-
   DateHistogram.php100.00%100.00%-
   DateRange.php100.00%100.00%-
   GeoDistance.php95.00%80.00%-
   Histogram.php100.00%100.00%-
   MultiTerms.php100.00%100.00%-
   QueryGroup.php100.00%100.00%-
   ReverseNested.php100.00%100.00%-
   SignificantTerms.php100.00%100.00%-
   Terms.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation/ConfigResolver
   CategoryAggregationConfigResolver.php5.56%33.33%-
   DateAggregationConfigResolver.php100.00%100.00%-
   FieldAggregationConfigResolverInterface.php---
   GeoDistanceAggregationConfigResolver.php100.00%100.00%-
   NumericAggregationConfigResolver.php100.00%100.00%-
   PriceAggregationConfigResolver.php100.00%100.00%-
   SelectAggregationConfigResolver.php100.00%100.00%-
   StockAggregationConfigResolver.php20.00%50.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation
   Coverage.php100.00%100.00%-
   CoverageProvider.php100.00%100.00%-
   Metric.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation/Modifier
   Coverage.php100.00%100.00%-
   ViewMore.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation/Pipeline
   AbstractPipeline.php100.00%100.00%-
   BucketSelector.php100.00%100.00%-
   MaxBucket.php100.00%100.00%-
   MovingFunction.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Aggregation/Provider
   AutocompleteSourceFields.php100.00%100.00%-
   CoverageAggregationProvider.php96.77%66.67%-
   FilterableSourceFields.php100.00%100.00%-
   GenericAggregationProvider.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request
   AggregationFactory.php100.00%100.00%-
   ContainerConfigurationInterface.php---
   PipelineInterface.php---
   QueryFactory.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Container/Configuration
   ContainerConfigurationProvider.php95.45%83.33%-
   GenericContainerConfiguration.php84.62%84.62%-
   GenericContainerConfigurationFactory.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Container/RelevanceConfiguration
   FuzzinessConfig.php80.00%75.00%-
   FuzzinessConfigurationInterface.php---
   RelevanceConfiguration.php100.00%100.00%-
   RelevanceConfigurationFactory.php100.00%100.00%-
   RelevanceConfigurationInterface.php---
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Request/Query
   Boolean.php100.00%100.00%-
   Common.php100.00%100.00%-
   DateRange.php100.00%100.00%-
   Exists.php100.00%100.00%-
   Filtered.php100.00%100.00%-
   FunctionScore.php100.00%100.00%-
   GeoDistance.php100.00%100.00%-
   MatchPhrasePrefix.php100.00%100.00%-
   MatchQuery.php100.00%100.00%-
   Missing.php100.00%100.00%-
   MoreLikeThis.php100.00%100.00%-
   MultiMatch.php100.00%100.00%-
   Nested.php100.00%100.00%-
   Not.php100.00%100.00%-
   Range.php100.00%100.00%-
   SpanNear.php100.00%100.00%-
   SpanTerm.php100.00%100.00%-
   Term.php100.00%100.00%-
   Terms.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Elasticsearch/Spellchecker
   Request.php100.00%100.00%-
   RequestFactory.php100.00%100.00%-
   RequestInterface.php---
/app/vendor/gally/gally-standard/src/Search/Entity
   Document.php100.00%100.00%-
   IngestPipeline.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Entity/Facet
   Configuration.php95.83%93.75%-
   Option.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/EventSubscriber
   GenerateFacetConfigurationId.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/GraphQl/Type/Definition
   FieldFilterInputType.php90.63%60.00%-
   RequestTypeEnumType.php100.00%100.00%-
   SortEnumType.php100.00%100.00%-
   SortInputType.php100.00%100.00%-
   SortOptionType.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/GraphQl/Type/Definition/Filter
   BoolFilterInputType.php100.00%100.00%-
   DistanceFilterInputType.php70.24%50.00%-
   EqualTypeFilterInputType.php100.00%100.00%-
   ExistFilterInputType.php100.00%100.00%-
   FilterableFieldTrait.php100.00%100.00%-
   MatchFilterInputType.php100.00%100.00%-
   RangeFilterInputType.php86.67%80.00%-
/app/vendor/gally/gally-standard/src/Search/GraphQl/Type/Definition/SortOrder
   CategoryDefaultSortOrderProvider.php100.00%100.00%-
   LocationDefaultSortOrderProvider.php100.00%100.00%-
   PriceDefaultSortOrderProvider.php100.00%100.00%-
   ScalarSortOrderProvider.php100.00%100.00%-
   SelectDefaultSortOrderProvider.php100.00%100.00%-
   SortOrderProviderInterface.php---
   StockDefaultSortOrderProvider.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Hydrator
   FacetConfigurationHydrator.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/OpenApi
   SearchDecorator.php20.00%50.00%-
/app/vendor/gally/gally-standard/src/Search/OpenSearch
   ClientBuilder.php75.00%0.00%-
/app/vendor/gally/gally-standard/src/Search/Repository/Facet
   ConfigurationRepository.php91.18%75.00%-
/app/vendor/gally/gally-standard/src/Search/Repository/Ingest
   PipelineRepository.php95.83%75.00%-
/app/vendor/gally/gally-standard/src/Search/Resolver
   DummyResolver.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Serializer
   DocumentDenormalizer.php85.71%66.67%-
/app/vendor/gally/gally-standard/src/Search/Service/GraphQl
   FilterManager.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/Service
   ReverseSourceFieldProvider.php100.00%100.00%-
   ScopableRequestTypeConfiguration.php100.00%100.00%-
   SearchContext.php90.91%90.91%-
   SearchSettingsProvider.php100.00%100.00%-
   SortingOptionsProvider.php100.00%100.00%-
   ViewMoreContext.php100.00%100.00%-
/app/vendor/gally/gally-standard/src/Search/State
   DocumentProvider.php97.62%66.67%-
   Paginator.php78.57%55.56%-
   SortingOptionProvider.php80.00%50.00%-
/app/vendor/gally/gally-standard/src/Search/State/Facet
   ConfigurationCollectionProvider.php84.21%50.00%-
   ConfigurationItemProvider.php93.75%50.00%-
   ConfigurationProcessor.php88.24%33.33%-
   OptionProvider.php96.72%66.67%-
/app/vendor/gally/gally-standard/src/Search/Validator
   FilterableFieldConstraintValidator.php33.33%0.00%-
   ProductFieldConstraintValidator.php33.33%0.00%-
/app/vendor/gally/gally-standard/src/Security/Entity
   Authentication.php84.62%84.62%-
/app/vendor/gally/gally-standard/src/Security/OpenApi
   JwtDecorator.php1.72%50.00%-
/app/vendor/gally/gally-standard/src/Security/Resolver
   AuthenticationMutationResolver.php72.00%50.00%-
/app/vendor/gally/gally-standard/src/Stitching/Decoration/GraphQl/Type
   StitchingFieldsBuilder.php95.18%69.23%-
/app/vendor/gally/gally-standard/src/Stitching/Serializer/GraphQl
   StitchingNormalizer.php89.29%75.00%-
/app/vendor/gally/gally-standard/src/Stitching/Service
   SerializerService.php97.22%80.00%-
/app/vendor/gally/gally-standard/src/Test
   AbstractEntityTestCase.php---
   AbstractEntityTestWithUpdate.php---
   AbstractTestCase.php---
   ExpectedResponse.php---
   RequestGraphQlToTest.php---
   RequestToTest.php---
/app/vendor/gally/gally-standard/src/User/Command
   CreateCommand.php0.00%0.00%-
   UpdateCommand.php0.00%0.00%-
/app/vendor/gally/gally-standard/src/User/Entity
   User.php93.33%90.00%-
/app/vendor/gally/gally-standard/src/User/Repository
   UserRepository.php16.67%50.00%-
/app/vendor/gally/gally-standard/src/User/Service/Command
   QuestionBuilder.php100.00%100.00%-
   Validation.php96.00%83.33%-
   Validator.php97.67%80.00%-
/app/vendor/gally/gally-standard/src/User/Service
   UserManager.php95.65%83.33%-
/app/vendor/gally/gally-standard/src/Validator
   DateRange.php100.00%100.00%-

Backend Coverage of this branch

Copy link

Frontend Coverage of this branch

File Coverage
All files 22%
src/components/App/App.tsx 0%
src/components/Cms/Pages.tsx 0%
src/components/Facets/Facet.styled.tsx 0%
src/components/Facets/Facet.tsx 0%
src/components/Facets/FacetBoolean.tsx 0%
src/components/Facets/FacetCategory.tsx 0%
src/components/Facets/FacetChoice.tsx 0%
src/components/Facets/FacetLoadMore.tsx 0%
src/components/Facets/FacetSlider.tsx 0%
src/components/Facets/Facets.tsx 0%
src/components/Header/Header.tsx 59%
src/components/Layout/Layout.tsx 0%
src/components/Menu/Menu.tsx 0%
src/components/Menu/MenuItem.tsx 0%
src/components/Menu/MenuList.tsx 0%
src/components/PageLayout/PageLayout.tsx 0%
src/components/PageTitle/PageTitle.tsx 0%
src/components/Products/ProductCard.tsx 0%
src/components/Products/Products.tsx 0%
src/components/Providers/AppProvider/AppProvider.tsx 0%
src/components/Providers/CatalogProvider/CatalogProvider.tsx 0%
src/components/Providers/CategoryProvider/CategoryProvider.tsx 0%
src/components/Providers/ConfigurationsProvider/ConfigurationsProvider.tsx 0%
src/components/Providers/ExtraBundlesProvider/ExtraBundlesProvider.tsx 0%
src/components/Providers/SchemaProvider/SchemaProvider.tsx 0%
src/components/Providers/SchemaProvider/RequestedPathProvider/RequestedPathProvider.tsx 0%
src/components/Providers/SearchProvider/SearchProvider.tsx 0%
src/components/Providers/UserProvider/UserProvider.tsx 0%
src/components/Search/Search.styled.tsx 0%
src/components/SearchBar/SearchBar.tsx 3%
src/components/Tabs/TabPanel.tsx 0%
src/components/Tabs/Tabs.tsx 0%
src/components/Tabs/a11yProps.tsx 0%
src/components/Title/Title.tsx 0%
src/components/TwoColsLayout/TwoColsLayout.tsx 0%
src/components/VectorSearch/ProductList.tsx 0%
src/hooks/index.ts 0%
src/hooks/useApi.ts 84%
src/hooks/useDocuments.ts 57%
src/hooks/useGraphql.ts 89%
src/hooks/useProducts.ts 48%
src/hooks/useUser.ts 95%
src/hooks/useVectorSearchDocuments.ts 57%
src/pages/Category/Category.tsx 0%
src/pages/Homepage/Homepage.tsx 0%
src/pages/Login/Login.tsx 0%
src/pages/Search/CmsSearch.tsx 0%
src/pages/Search/ProductSearch.tsx 0%
src/pages/Search/Search.tsx 0%
src/pages/VectorSearch/VectorSearch.tsx 0%

Minimum allowed coverage is 1%

Generated by 🐒 cobertura-action against 7033519

@botisSmile botisSmile merged commit db6b81f into master Oct 28, 2024
5 checks passed
@botisSmile botisSmile deleted the feat-1317036-1317038-ExampleAppDateLocationInEq branch October 28, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example-app PR targets the frontend example app frontend PR targets frontend application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants