-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1416] Add shielded transaction type recognition support #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust updates and cleanups
This includes support for creating transaction proposals that send to TEX addresses.
This fixes several existing issues: - The Rust backend's `proposeTransfer` expected to receive `null` for no memo, but was instead receiving an empty array. `proposeShielding` meanwhile was always expecting a memo. - The Kotlin side had nullable byte arrays, but then always converted an empty string to an empty byte array instead of `null`.
Filed a follow-up issue #1534
ZIP 320 (TEX address) support
* Exchange rates API refactor * Code cleanup * Demo app updates * Exchange rate implementation * Detekt and ktlint checks * Code cleanup
# Conflicts: # CHANGELOG.md # sdk-lib/src/main/java/cash/z/ecc/android/sdk/SdkSynchronizer.kt # sdk-lib/src/main/java/cash/z/ecc/android/sdk/Synchronizer.kt
Add `Synchronizer` APIs for USD/ZEC exchange rate
* Tor initialization and disposal * Code cleanup
# Conflicts: # CHANGELOG.md # backend-lib/Cargo.lock # backend-lib/Cargo.toml # sdk-incubator-lib/src/main/java/cash/z/ecc/android/sdk/model/FiatCurrencyConversionExt.kt # sdk-incubator-lib/src/main/java/cash/z/ecc/android/sdk/model/ZatoshiExt.kt # sdk-lib/src/androidTest/java/cash/z/ecc/fixture/FakeRustBackend.kt # sdk-lib/src/main/java/cash/z/ecc/android/sdk/model/FiatCurrency.kt
str4d
reviewed
Sep 9, 2024
HonzaR
reviewed
Sep 9, 2024
sdk-lib/src/main/java/cash/z/ecc/android/sdk/model/TransactionOverview.kt
Outdated
Show resolved
Hide resolved
HonzaR
changed the title
[#1416] Shielded transaction support
[#1416] Add shielded transaction type recognition support
Sep 11, 2024
Closes #1416
HonzaR
approved these changes
Sep 11, 2024
# Conflicts: # CHANGELOG.md
Post-hoc utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author
Reviewer
Footnotes
Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs. ↩
While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test
something during development of this pull request, write those steps down. ↩
While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with:
./gradlew check
for Kotlin modules and./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true
for Android modules. ↩Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit. ↩
In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass. ↩
While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are
more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally. ↩