Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes and feature additions #172

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

kadirozdinc
Copy link
Contributor

My additions and corrections :

  • Class C behavior was wrong, right after sending uplink, device opens RX2 continously with fixed SF,BW and Frequency. Therefore device could not hear any downlink on RX1 window. With my changes, device can hear downlink messages including ACK bit.
    (Refer to : https://lora-developers.semtech.com/documentation/tech-papers-and-guides/lorawan-class-c-devices/
    https://lora-alliance.org/resource_hub/rp002-1-0-0-lorawan-regional-parameters/ )

  • For class selection, I add a definition in Config file. When you define it, mode will be Class C otherwise Class A.

  • I changed message receiving structure. I made it with callback function to provide a bit of abstraction.

  • I add "isConfirmed" feature to be able to send ACK info in case we get confirmed downlink from NS.

  • I create sendACK function In case of getting confirmed downlink.

  • I correct readAck function by eding a line of code to clear previous ACK bit.

I use Chirpstack NS and test the example code I added, It works great.

I am sorry that I make changes a bit of carelessly since I dont have sufficent time, I couldn't do all the thing I want to do.

If I have more time, I will go on developing...

kadirozdinc and others added 4 commits July 26, 2023 11:05
@kadirozdinc kadirozdinc changed the title Changes I made are Some changes and feature additions Jul 27, 2023
@wero1414
Copy link
Member

wero1414 commented Aug 2, 2023

Hello!

Thanks for all the work!

As the changes are some, i will take some days to test and read all

Thanks again!

Copy link
Member

@wero1414 wero1414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the print on the lora cycle far from that it is working great, i really like the addition on a callback for messages

src/arduino-rfm/LoRaMAC.cpp Outdated Show resolved Hide resolved
Copy link
Member

@sabas1080 sabas1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove "&" from the example name, this may break internet or OS, I suggest "Class-C-OTA-ACK"

@wero1414 wero1414 dismissed sabas1080’s stale review August 31, 2023 23:14

the change has already been done

@wero1414 wero1414 merged commit 15596e6 into ElectronicCats:master Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants