DIO pin optional #188
Merged
DIO pin optional #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello sacua, thank you for your interest in contributing to our library. I am fine with what you suggest, I will do a quick review and proceed with the approval since I consider it was already ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I realize my previous pull request (#184) was not very "pull request friendly." It contained several distinct objectives, making it challenging to discuss and merge.
To improve clarity and ease of review, I've decided to break down the changes into separate pull requests. This pull request focuses on making the DIO pin optional.
The upcoming pull requests will address modifications to make the code more "deep sleep friendly" for ESP devices, customizable RX delay and windows (note that Things Stack uses a 5-second delay for RX1), and lastly, cleaning up the TX power settings.
Thanks,