remove shouldCancel

ElegantEngineeringTech · Sep 22, 2024 · 3aa2dc9 · 3aa2dc9
1 parent a078d36
commit 3aa2dc9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/src/Models/Workflow.php b/src/Models/Workflow.php
@@ -245,6 +245,8 @@ public function markStepAsCanceled(string $name): static
 
     public function run(): void
     {
+        $this->definition->beforeRun($this);
+
         if (
             $this->isFinished() ||
             $this->isFailed() ||
@@ -253,18 +255,10 @@ public function run(): void
             return;
         }
 
-        if ($this->definition->shouldCancel($this)) {
-            $this->markAsCanceled();
-
-            return;
-        }
-
         if (! $this->definition->shouldRun($this)) {
             return;
         }
 
-        $this->definition->beforeRun($this);
-
         $this->definition->run($this);
 
         $this->definition->afterRun($this);

diff --git a/src/WorkflowDefinition.php b/src/WorkflowDefinition.php
@@ -30,11 +30,6 @@ public function start(): Workflow
         return $workflow;
     }
 
-    public function shouldCancel(Workflow $workflow): bool
-    {
-        return false;
-    }
-
     public function shouldRun(Workflow $workflow): bool
     {
         return true;