Fix SequentialWrapper Generation (pipe_parallel_size = 0) #1031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the following bug for generating with
pipe_parallel_size = 0
Bug Reproduce
set
pipe_parallel_size = 0
The following error occurres when generating with
pipe_parallel_size = 0
The above procedure is easy to reproduce.
Analysis
The right size of attention_mask should be [1, 1, 1, 1] for
generation_step > 1
.Root Cause
The sequential generation process (
SequentialWrapper
) is missing abatch_fn
, which leads to bad size of attention_mask.gpt-neox/megatron/training.py
Lines 643 to 655 in c883e8c
Similar implementation can be found in PipelineEngine deepspeed/runtime/pipe/engine.py#L-578
pipe_parallel_size > 0