Edge-casing for multi-GPU HF-to-NeoX conversion #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-Anthony
approved these changes
Nov 1, 2023
R0n12
pushed a commit
to R0n12/gpt-neox-fork
that referenced
this pull request
Nov 2, 2023
* edge-casing for multiGPU hf to sequential case * cleanup whitespace * Update NeoXArgs docs automatically * Update NeoXArgs docs automatically --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Quentin Anthony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs encountered when attempting to convert from HF to NeoX checkpoint format, via the invocation of the script through
deepy.pyin the multi-GPU case.After fixing these, and using
"launcher": "slurm", "deepspeed_slurm": truein the config file I passed, conversion works for this distributed case. The distributed case can be always used if desired, even on a single GPU, and whether or not MP/PP are > 1.