Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update from main #1089

Merged
merged 4 commits into from
Dec 4, 2023
Merged

update from main #1089

merged 4 commits into from
Dec 4, 2023

Conversation

StellaAthena
Copy link
Member

No description provided.

jahatef and others added 4 commits November 15, 2023 19:24
* Update neox_args.py

These attention configuration options were missing from the docs. This will fix that.

* Update NeoXArgs docs automatically

---------

Co-authored-by: github-actions <[email protected]>
* Update README.md

* Update NeoXArgs docs automatically

---------

Co-authored-by: github-actions <[email protected]>
* Use `.yml` extensions in README to reflect extensions used in `configs/` folder

* Rename `save_interval` -> `checkpoint_factor`

* Mark expected failures in existing tests

* Fix minor typos

* Allow creation of checkpoint at iteration 0 when `do_train=False`

Helpful for unit tests because it allows use of a randomly initialised model

* Delete duplicated `test_fused_kernels.py`

Primary version lives in `tests/model/test_fused_kernels.py`

* Avoid initializing CUDA whenever `megatron` is imported

Resolves `Cannot re-initialize CUDA in forked subprocess` error when running distributed unit tests

* Extend suite of unit tests
@StellaAthena StellaAthena requested a review from a team as a code owner December 4, 2023 18:09
@StellaAthena StellaAthena requested review from Quentin-Anthony and ShivanshuPurohit and removed request for a team December 4, 2023 18:09
@StellaAthena StellaAthena merged commit feb1433 into fused-rope Dec 4, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants