Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE Import Hotfix #1272

Merged
merged 3 commits into from
Sep 9, 2024
Merged

TE Import Hotfix #1272

merged 3 commits into from
Sep 9, 2024

Conversation

Quentin-Anthony
Copy link
Member

@Quentin-Anthony Quentin-Anthony commented Sep 9, 2024

Change the TE import to be properly conditional. I didn't catch it in #1269 since I had tested it with TE installed (oops!)

Refactored this function while I was around.

@aurelion-source -- FYI

@Quentin-Anthony Quentin-Anthony merged commit 61a3daa into main Sep 9, 2024
2 of 5 checks passed
@Quentin-Anthony Quentin-Anthony deleted the qanthony/te-import branch September 9, 2024 01:48
@aurelion-source
Copy link
Contributor

aurelion-source commented Sep 9, 2024

Change the TE import to be properly conditional. I didn't catch it in #1269 since I had tested it with TE installed (oops!)

Refactored this function while I was around.

@aurelion-source -- FYI

@Quentin-Anthony
#1269 was tested with and w/o TE installed. It looks like this file was overwritten:
https://github.com/aurelion-source/gpt-neox/blob/bdfb8a1e119b4989ef685334e3bf3162542728b4/megatron/model/utils.py#L40

My previous merge resolution was ignored due to closing and re-opening the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants