-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Last Update (Timestamp)" Column Dynamically When Quota is Reached #127
base: master
Are you sure you want to change the base?
Conversation
Currently does nothing but gets read and validated
…pefully Trying to debug "Exception: The number of rows in the range must be at least 1."
not anymore |
…ill need to update adding videos to playlists and handling exceeding quota there
README.md
Outdated
@@ -41,7 +37,7 @@ If you ran into problems, here are some of the possible sources for solutions: | |||
1. [Copy](http://bit.ly/subscriptionPlaylistsCopy) the Sheet to your Google Drive. | |||
Afterwards you might want to update the script to the latest version of sheetScript.gs | |||
|
|||
2. Setup your playlists and channels (white cells in the Sheet): | |||
1. Setup your playlists and channels (white cells in the Sheet): | |||
- Clear all existing white rows, they are just examples (i.e. delete the 3 rows). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now. Looks good there and I also noticed a couple other places it was misaligned
if (nextTime && dateDiff <= nextTime) { | ||
var lastDate = new Date(lastTimestamp); | ||
var lastTime = lastDate.getTime(); | ||
var dateDiff = Date.now() - lastTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, we can just subtract two date objects, aka new Date() - lastDate
, and we don't need to create lastTime
What if instead of catching the quota error everywhere, we pushed it to the top level. Since quota refreshes daily, there should be no need to continue the script if a single quota error is hit. |
If you can also show how you've tested these changes, it'll help me review much faster. Otherwise I'll need to test it myself. |
Sorry I've had a lot going on but I'm back and I'll try to address your comments soon |
No description provided.