fix: add d-forward-decl-or-cast-1 function optional param
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken (as of Emacs 29) call to `d-forward-decl-or-cast-1` advice function due to apparent change in `c-forward-decl-or-cast-1` function definition specifying an optional `inside-macro` param. See 'cc-engine.el'. More work may be needed to support the optional parameter but for now just get font locking working again.
CyberShadow
merged commit 0c8c9e3
into
Emacs-D-Mode-Maintainers:master
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken (as of Emacs 29) call to
d-forward-decl-or-cast-1advice function due to apparent change inc-forward-decl-or-cast-1function definition specifying an optionalinside-macroparam, which causes most fontification to break. See 'cc-engine.el'. More work may be needed to support the optional parameter but for now just get font lock working again.Tested on Emacs 29; not yet tested on prior versions of Emacs (if anyone could help with that, that would be appreciated). Guidance on how to update unit tests is also welcome, as this is my first contribution.