Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow builder to set ActivityKind #40

Merged
merged 2 commits into from
Sep 2, 2024
Merged

feat: allow builder to set ActivityKind #40

merged 2 commits into from
Sep 2, 2024

Conversation

w-lfchen
Copy link
Contributor

@w-lfchen w-lfchen commented Sep 1, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This pr adds a simple method to the ActivityBuilder that allows setting the ActivityKind field of the underlying ActivityArgs.
The test case testing the builder has been updated to utilize this new method.

Additional Notes/Questions

  • The links to the contributor guide and the coc in the pr template don't work
  • Should I update the docs somewhere to point out that not all ActivityKind types are supported?
    We could link to here, but I'm not sure where I should put this.
  • Should I run cargo update?
    I don't think it'll cause any issues and dependencies should be kept up to date

Related Issues

#38 allowed for serialization of this field, so I think it's only logical to allow it to be set in the builder as well.

@w-lfchen w-lfchen changed the title Feat/kind feat: allow builder to set ActivityKind Sep 1, 2024
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit fbfd3f2 into EmbarkStudios:main Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants