feat: allow builder to set ActivityKind #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This pr adds a simple method to the
ActivityBuilder
that allows setting theActivityKind
field of the underlyingActivityArgs
.The test case testing the builder has been updated to utilize this new method.
Additional Notes/Questions
ActivityKind
types are supported?We could link to here, but I'm not sure where I should put this.
cargo update
?I don't think it'll cause any issues and dependencies should be kept up to date
Related Issues
#38 allowed for serialization of this field, so I think it's only logical to allow it to be set in the builder as well.