Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 and add export functionality. #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

classner
Copy link

Hi folks!

Thanks for the great work with the torch plugin! I had a stab at fixing the problem in #21 , and also added the functionality for pdm torch export [...] so that requirement files can be generated.

In the process I noticed that the +cpu build identifier is unfortunately not universal (it doesn't work for Mac builds) and think it's okay to omit it for CPU builds, just let me know if that's not the case.

@classner classner requested a review from tgolsson as a code owner February 26, 2024 04:00
@polarathene
Copy link

I noticed that the +cpu build identifier is unfortunately not universal (it doesn't work for Mac builds)

+cpu local identifier is only assigned to x86_64 (AMD64) packages, PyTorch doesn't publish the aarch64 (ARM64) packages with that as there is no other GPU variants supported on that platform that PyTorch publishes (if you need CUDA compatible torch packages for aarch64 hardware like the Jetson, you'd need to install torch another way such as the containers nvidia publishes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants