Add command to configure project for order files #7
Conversation
| desc 'Configure order files for iOS' | ||
|
|
||
| # Optional options | ||
| option :only_enable_linkmaps, type: :boolean, required: false, desc: 'Only enable linkmaps' |
There was a problem hiding this comment.
This option is a bit confusing, not sure what it's doing.
There was a problem hiding this comment.
I see below it's related to the download script, maybe that could instead be skip_download_script?
| Logger.info " Creating script 'Download Order Files'" | ||
| phase = target.new_shell_script_build_phase('Download Order Files') | ||
| phase.shell_script = "\ | ||
| if [ \"$CONFIGURATION\" != \"Release\" ]; then |
There was a problem hiding this comment.
Would using a heredoc avoid all the escaping, or is that necessary for the script itself?
There was a problem hiding this comment.
Never tried heredoc, time to test it
| # Create the script phase if it doesn't exist | ||
| phase = target.shell_script_build_phases.find { |item| item.name == 'Download Order Files' } | ||
| if phase.nil? | ||
| Logger.info " Creating script 'Download Order Files'" |
There was a problem hiding this comment.
nit: I would prefix with our name, e.g. EmergeTools Download Order Files
lib/emerge_cli.rb
Outdated
| @@ -30,6 +31,7 @@ module EmergeCLI | |||
|
|
|||
| register 'configure' do |prefix| | |||
| prefix.register 'snapshots-ios', Commands::Config::SnapshotsIOS, aliases: ['c'] | |||
| prefix.register 'order-files-ios', Commands::Config::OrderFilesIOS, aliases: ['o'] | |||
There was a problem hiding this comment.
nit: I'm thinking maybe we want to avoid aliases for the subcommands and instead have one for configure? Also the c above for 'snapshots-ios' is probably a mistake.
No description provided.