Sync repo to upstream #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improvements to the project setup. added .ruby-version. * added step about terminal configuration.
* Basic fake language picker support * Recognize languages from post text * Exclude suggested languages from recents * Load recent languages from Settings object * Send the language to the API * Persist the used language to settings * Always show the currently selected language in the list * Fix crash * Add support for picking arbitrary lanuages * Fix display of 3 letter language codes * Improve label to include endonym too * Limit to 3 recent languages * Reduce lower bound for displaying language suggestions * Fix saving recent language when publishing * Fix tint color of language picker button * Add a badge to prompt users to change language * Dismiss the badge even if you pick the same language * Read language names in the language if possible * Use a compressed font for 3-letter codes Also use `minimumScaleFactor` to shrink troublesome codes to fit Co-Authored-By: samhenrigold <[email protected]> * Remove .vscode/launch.json * Add message to fatalError() Co-authored-by: samhenrigold <[email protected]>
The secret is to set the delegate before getting the account. This doesn't feel right.
We need this viewModel for the button--state of the follow-button. There's still a runtime-issue that resets the button-state to follow.
Thanks to @kimar for pointing this out!
Reason for button-state not working/updating feels like to be a weird combination of Combine, UIKit, Snapshots, CoreData and me being stupid and not getting a hang on it.
aka when account-suggestion-screen
Follow-button wasn't attached to the right side
Wasn't tappable on iPhone
…todon Better UI/UX for suggestions for new users (IOS-157)
…/update-from-upstream # Conflicts: # Mastodon.xcodeproj/project.pbxproj
2 builds increased size
Mastodon 2023.10 (1)⚖️ Compare build
Largest size changes
Mastodon 2023.10 (1)⚖️ Compare build Total install size change: ⬆️ 344.6 kB (0.56%) Largest size changes
🛸 Powered by Emerge Tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.