Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show shader message #18

Merged
merged 2 commits into from
Aug 11, 2023
Merged

do not show shader message #18

merged 2 commits into from
Aug 11, 2023

Conversation

n-at
Copy link

@n-at n-at commented Aug 11, 2023

Do not show shader change message (on every startup and on change in menu).
Will help with EmulatorJS/EmulatorJS#585

@ethanaobrien
Copy link
Member

Can we surround this with #ifndef EMULATORJS, similar to how I removed the menu messages. It helps decrease the possibility of merge conflicts

@n-at
Copy link
Author

n-at commented Aug 11, 2023

Ok, restored code and added #ifdef

@ethanaobrien
Copy link
Member

Awesome, thank you!

@ethanaobrien ethanaobrien merged commit 2700160 into EmulatorJS:master Aug 11, 2023
20 of 22 checks passed
@zmarteline
Copy link

The message still there.

@n-at n-at mentioned this pull request Aug 12, 2023
Merged
@n-at
Copy link
Author

n-at commented Aug 12, 2023

I've mistaken there, it should be ifndef, opened a PR to fix this.

@zmarteline
Copy link

Please don't forget this... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-at @ethanaobrien @zmarteline