Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Sidebar stylistic improvements #60

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Mar 14, 2024

This PR introduces some stylistic improvements to the sidebar to make it less confusing.

  • Change the sub-list expand arrow colour to match the font colour. Before it was black and dark grey background and really hard to see.
  • Consistently position the sub-list expand arrow to the right of the menu item. Before it's position was inconsistent due to a cross reference from CategoryManagement.vue
  • Change the "active selection highlight" to a tinted, right border. Before highlighting was achieved by moving the selected item to the left. Moving items feel like bad UX and it doesn't really work well for sub-menu items.
  • Adds a small lock indicator 🔒 when a page or sub page is password protected

Preview:
image

Before:
image

@dmohns dmohns changed the base branch from main to chore-add-prettier March 14, 2024 15:51
@dmohns dmohns changed the title Chore sidebar stylistic improvements ui: Sidebar stylistic improvements Mar 14, 2024
Base automatically changed from chore-add-prettier to main March 15, 2024 11:29
@dmohns dmohns force-pushed the chore-sidebar-stylistic-improvements branch from 39a43e9 to 2e3ea6a Compare March 15, 2024 14:03
@dmohns dmohns force-pushed the chore-sidebar-stylistic-improvements branch from 4508bbb to d43bd11 Compare March 15, 2024 15:41
@dmohns dmohns merged commit e4b9109 into main Mar 20, 2024
8 checks passed
@dmohns dmohns deleted the chore-sidebar-stylistic-improvements branch March 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant