Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove redundant SCSS file #65

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

dmohns
Copy link
Member

@dmohns dmohns commented Mar 18, 2024

Removing (essentially) redundant file as everything is already covered in Website/ui/src/assets/sass/mpm/_sidebar-and-main-panel.scss

--- Website/ui/src/assets/sass/mpm/_sidebar.scss        2024-03-18 10:51:06
+++ Website/ui/src/assets/sass/mpm/_sidebar-and-main-panel.scss 2024-03-15 12:29:42
@@ -19,6 +19,7 @@
 
 .wrapper .sidebar,
 .wrapper .off-canvas-sidebar {
+    overflow: scroll;
     position: fixed;
     top: 0;
     bottom: 0;
@@ -65,6 +66,7 @@
         height: calc(100vh - 75px);
         overflow: auto;
         z-index: 4;
+        overflow-x: hidden;
 
         .dropdown .dropdown-backdrop {
             display: none !important;
@@ -259,7 +261,7 @@
         position: absolute;
         width: 100%;
         height: 100%;
-        background-color: rgba(27, 27, 27, 0.87);
+        /* background-color: rgba(27, 27, 27, 0.87);*/
         opacity: 0.85;
         top: 0;
         left: 0;
@@ -315,8 +317,9 @@
     @include transition(0.33s, cubic-bezier(0.685, 0.0473, 0.346, 1));
 
     > .content {
-        padding: 30px 15px;
+        padding: 1vh 0.5vw;
         min-height: calc(100vh - 123px);
+        overflow-y: hidden;
     }
 
     > .footer {
@@ -327,3 +330,14 @@
         margin-bottom: 0;
     }
 }
+
+// .sidebar,
+// .main-panel{
+//     -webkit-transition-property: top,bottom;
+//     transition-property: top,bottom;
+//     -webkit-transition-duration: .2s,.2s;
+//     transition-duration: .2s,.2s;
+//     -webkit-transition-timing-function: linear,linear;
+//     transition-timing-function: linear,linear;
+//     -webkit-overflow-scrolling: touch;
+// }

@dmohns dmohns requested a review from a team March 18, 2024 09:53
@dmohns dmohns merged commit 16f4586 into main Mar 20, 2024
8 checks passed
@dmohns dmohns deleted the chore-remove-duplicate-css-files branch March 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant