lien docker compose #1285
Merged
lien docker compose #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change is OK but the commit message should be in english |
bpeytraud
force-pushed
the
guide-docker-intro
branch
from
c66e55f
to
d962967
Compare
vaceletm
reviewed
Nov 17, 2023
| @@ -16,7 +16,7 @@ It allows you to not be bothered by different OS migrations and the like. | |||
| Prerequisites | |||
| ````````````` | |||
|
|
|||
| You need docker on your host. You might want docker-compose as well. | |||
| You need docker on your host. You might want `docker-compose <https://docs.docker.com/engine/install/>`_ as well. | |||
There was a problem hiding this comment.
Shouldn't you link toward https://docs.docker.com/compose/ ?
There was a problem hiding this comment.
Plus, I'm wondering why you added a link on docker compose but not on docker
There was a problem hiding this comment.
No, because you want to have an explication of how to install docker compose depending of your environment. In my link you have all the command to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout de lien pour réaliser l'installation de docker compose