-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gst_video_sync integration test #408
base: master
Are you sure you want to change the base?
Conversation
rospy.sleep(1) | ||
|
||
with self.assertRaises(subprocess.CalledProcessError): | ||
subprocess.check_call([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subprocess call - check for execution of untrusted input.
rospy.sleep(1) | ||
|
||
with self.assertRaises(subprocess.CalledProcessError): | ||
subprocess.check_call([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting a process with a partial executable path
self.scene_pub.publish(GenericMessage(type='json', message=json.dumps(scene))) | ||
rospy.sleep(1) | ||
|
||
subprocess.check_call([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subprocess call - check for execution of untrusted input.
self.scene_pub.publish(GenericMessage(type='json', message=json.dumps(scene))) | ||
rospy.sleep(1) | ||
|
||
subprocess.check_call([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting a process with a partial executable path
import unittest | ||
import rospy | ||
import json | ||
import subprocess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider possible security implications associated with subprocess module.
SourceLevel has finished reviewing this Pull Request and has found:
But beware that this branch is 41 commits behind the You can see more details about this review at https://app.sourcelevel.io/github/EndPointCorp/lg_ros_nodes/pulls/408. |
No description provided.