-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding in console to use dev shell #437
Open
minshallj
wants to merge
3
commits into
master
Choose a base branch
from
dev_console2.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
#!/usr/bin/env bash | ||
|
||
./scripts/init_workspace | ||
|
||
[ -e ../appctl/appctl ] && ./scripts/init_workspace -x ${PWD}/../appctl/appctl | ||
constantegonzalez marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/usr/bin/env bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should use a |
||
|
||
cd "$(dirname "$0")/.." | ||
|
||
./scripts/bootstrap | ||
|
||
[[ "$(docker images | grep -c lg_ros_nodes.*latest)" == 0 ]] && ./scripts/update | ||
|
||
MOUNTS="" | ||
|
||
for rosnode in $(ls catkin/src/* -d | grep -v CMake); do | ||
# $rosnode is catkin/src/package_name | ||
MOUNTS="${MOUNTS} -v $(readlink ${rosnode}):/src/lg_ros_nodes/${rosnode}" | ||
done | ||
|
||
echo ${MOUNTS} | ||
|
||
docker run ${MOUNTS} -it lg_ros_nodes:latest /bin/bash -c " | ||
cd /src/lg_ros_nodes/catkin | ||
source devel/setup.bash | ||
source ../scripts/docker_xvfb_add.sh | ||
echo 'run catkin_make before anything' | ||
/bin/bash | ||
" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
#!/usr/bin/env python | ||
#!/usr/bin/env python3 | ||
|
||
import os | ||
import argparse | ||
from subprocess import Popen | ||
from ConfigParser import RawConfigParser, NoSectionError, NoOptionError | ||
from configparser import RawConfigParser, NoSectionError, NoOptionError | ||
|
||
# make sure to set the root directory | ||
ROOT_DIR = os.path.realpath(os.curdir) | ||
|
@@ -37,7 +37,7 @@ def parse_config(): | |
""" | ||
config_file = 'scripts/init.cfg' | ||
if not os.path.exists(config_file): | ||
print 'WARNING, no %s found, using possibly outdated configuration' % config_file | ||
print('WARNING, no %s found, using possibly outdated configuration' % config_file) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Single or double quotes? |
||
return # rely on hard coded values... maybe an exception would work | ||
# setting these globals | ||
global IGNORE_DIRS | ||
|
@@ -186,9 +186,9 @@ def check_validity(): | |
for needed in NEEDED_DIRS: | ||
if needed not in links: | ||
passed = False | ||
print "############## WARNING catkin/src SHOULD HAVE %s LINK ##############" % needed | ||
print("############## WARNING catkin/src SHOULD HAVE %s LINK ##############" % needed) | ||
if passed: | ||
print "Successfully completed workspace initialization" | ||
print("Successfully completed workspace initialization") | ||
|
||
|
||
def main(): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/usr/bin/env bash | ||
|
||
cd "$(dirname "$0")/.." | ||
docker build . -t lg_ros_nodes |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a comment here?