Merge branch 'main' into aiu/update_audit_source_for_calculations

.github/workflows/ci-orchestrator.yml

@@ -35,12 +35,6 @@ jobs:
     secrets:
       dh3serviceaccount_privatekey: ${{ secrets.dh3serviceaccount_privatekey }}
 
-  #
-  # CodeQL Check
-  #
-  ci_codeql:
-    uses: ./.github/workflows/codeql.yml
-
   #
   # Detect changes to start relevant workflows
   #
@@ -92,7 +86,6 @@ jobs:
     needs:
       [
         ci_base,
-        ci_codeql,
         dh_ci_frontend,
         dh_ci_dotnet,
         watt_ci,

README.md

@@ -304,9 +304,8 @@ The repository is using [GitHub Actions workflows](https://docs.github.com/en/ac
 for automation including CI/CD pipelines for each application.
 Workflows are located in `.github/workflows` which currently contains the following:
 
-- `ci-orchestrator.yml` - Markdown check and YAML validation, CodeQL check, renders C4 model diagrams, detects changes to start relevant workflows and branch policy status check.
+- `ci-orchestrator.yml` - Markdown check and YAML validation, renders C4 model diagrams, detects changes to start relevant workflows and branch policy status check.
 - `clean-up-cache.yml` - Cleanup GitHub workflow caches for closed branches.
-- `codeql.yml` - Performs CodeQL Analysis.
 - `create-tokens.yml` - Generates design tokens based on a JSON file exported from Figma.
 - `detect-changes.yml` - Figures out what part of the codebase is affected by a change.
 - `dh-cd.yml`: Used by DataHub for updating BFF code coverage, publishing a release, dispatching a deployment request, and dispatching a notification on failure.

apps/dh/api-dh/documents/development.md

@@ -93,7 +93,7 @@ To create a new query using Hot Chocolate, follow this example:
                 new Book { Id = 1, Title = "The Great Gatsby", Author = "F. Scott Fitzgerald" },
                 new Book { Id = 2, Title = "To Kill a Mockingbird", Author = "Harper Lee" }
             }
-        
+
         // ...
     }
     ```
@@ -175,8 +175,7 @@ The current subsystem clients can be found at:
 Update the subsystem clients using NSwag:
 
 - Delete the respective `swagger.json` file, eg. `apps/dh/api-dh/source/DataHub.WebApi/Clients/Wholesale/V3/swagger.json`
-- Make sure you have access to the `swagger.json` source mentioned in the respective `nswag.json` file
-    Example from the `apps/dh/api-dh/source/DataHub.WebApi/Clients/Wholesale/V3/nswag.json` config:
+- Make sure you have access to the `swagger.json` source mentioned in the respective `nswag.json` file. **You might have to connect using VPN.** Example from the `apps/dh/api-dh/source/DataHub.WebApi/Clients/Wholesale/V3/nswag.json` config:
 
     ```json
     {