Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watt): VaterSpacer and VaterUtility #2005

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Conversation

ManBearTM
Copy link
Contributor

Description

As a response to some of the feedback on vater, this PR aims to make it a little bit smarter by adding support for common utility (+ the spacer component).

@cla-bot cla-bot bot added the cla-signed label Sep 1, 2023
@nx-cloud
Copy link

nx-cloud bot commented Sep 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cce1c79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

[DH3 Frontend App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

[Energy Origin App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@mimse mimse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks for me

@ManBearTM ManBearTM merged commit 1cdc12d into main Sep 1, 2023
39 checks passed
@ManBearTM ManBearTM deleted the feat/more-vater-components branch September 1, 2023 12:39
CodeReaper added a commit that referenced this pull request Sep 4, 2023
* main:
  feat(dh): use vater in calculations (#2006)
  feat(watt): VaterSpacer and VaterUtility (#2005)
  Allow stop of issuance of gcs for metering point (#1968)
  Preview/1609 new date (#1977)
  Add warning when deactivating user. (#2003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants