-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dh): add input to sort dropdown entries by translation key order #3649
Merged
ManBearTM
merged 22 commits into
main
from
feat/dropdown-translator-sort-by-translation-keys
Oct 21, 2024
Merged
feat(dh): add input to sort dropdown entries by translation key order #3649
ManBearTM
merged 22 commits into
main
from
feat/dropdown-translator-sort-by-translation-keys
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 06feeab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
dzhavat
previously approved these changes
Oct 21, 2024
mimse
previously approved these changes
Oct 21, 2024
dzhavat
previously approved these changes
Oct 21, 2024
dzhavat
approved these changes
Oct 21, 2024
ManBearTM
deleted the
feat/dropdown-translator-sort-by-translation-keys
branch
October 21, 2024 13:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
dhDropdownTranslator
to use the order of the translation keys to sort the dropdown options. It is still possible to sort the options by name (ASC or DESC) by using thesortDirection
input. But this change means that the order of the options (or source enum) is never considered when usingdhDropdownTranslator
. This in turn made thesort
parameter ofdhEnumToWattDropdownOptions
have no effect when used alongsidedhDropdownTranslator
. I decided to remove that feature fromdhEnumToWattDropdownOptions
, as I believe it leads to incorrect sorting anyway (it is not sorted by the translated text, but by enum values). Instead, usesortDirection
which considers the translated text, or for non-alphabetical sorting, order the translations accordingly in the translation files.