Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eo, auth): visualize self better in actor-menu #3650

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

frontend-specialisten
Copy link
Contributor

@frontend-specialisten frontend-specialisten commented Oct 21, 2024

Description

This pull request includes several updates to the eo-actor-menu component and related files to enhance functionality and improve the user interface. Notable changes include the addition of new components, updates to styles, and modifications to the actor selection logic.

Enhancements to eo-actor-menu Component:

  • Added EoScrollViewComponent and WattIconComponent to the imports and updated the template to include a new icon and scroll view. (libs/eo/auth/ui-actor-menu/actor-menu.component.ts)
  • Updated styles to include new CSS rules for the watt-icon and menu-header classes, improving the visual presentation of the actor menu. (libs/eo/auth/ui-actor-menu/actor-menu.component.ts) [1] [2]
  • Enhanced the actor selection logic to handle cases where the selected actor is not provided, defaulting to the current actor. (libs/eo/auth/ui-actor-menu/actor-menu.component.ts)

UI and Styling Adjustments:

  • Introduced new CSS variables for padding and max height in the eo-scroll-view component to allow for better customization. (libs/eo/shared/components/ui-scroll-view/eo-scroll-view.component.ts)

Data Mock Updates:

  • Added new mock data for received consents, expanding the list of organizations for testing purposes. (libs/eo/shared/data-access-mocks/src/lib/authorization.ts)
image

References

  • #0000

Copy link

nx-cloud bot commented Oct 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0166354. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@frontend-specialisten frontend-specialisten merged commit 7dcaa22 into main Oct 22, 2024
25 checks passed
@frontend-specialisten frontend-specialisten deleted the feat/show-self-actor branch October 22, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants