ETT: enhance TOS acceptance flow and add error handling #3659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the authentication and terms acceptance flow in the
eo/auth
library. The most important changes include updating the handling of token refresh URLs, improving theacceptTos
method to handle asynchronous operations, and adding a toast notification for error handling in the terms component.Authentication Improvements:
libs/eo/auth/data-access/auth.interceptor.ts
: Added a new URL to theignoreTokenRefreshUrls
array to include/api/authorization/terms/accept
.libs/eo/auth/data-access/auth.service.ts
: UpdatedacceptTos
method to uselastValueFrom
for asynchronous handling and added polling for TOS acceptance confirmation.libs/eo/auth/data-access/auth.service.ts
: ModifiedrefreshToken
method to be asynchronous and update the user state accordingly.libs/eo/auth/data-access/auth.service.ts
: UpdatedcheckForExistingToken
to set the user state directly.Terms Component Enhancements:
libs/eo/auth/feature-terms/terms.component.ts
: AddedWattToastService
for error notifications and updated thestartedAcceptFlow
to use a signal for reactive state management. [1] [2]libs/eo/auth/feature-terms/terms.component.ts
: Added error handling in theonAccept
method to display a toast notification if the TOS acceptance fails.References