Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETT: enhance refreshToken method with additional query parameters for login prompt #3660

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

frontend-specialisten
Copy link
Contributor

Description

This pull request introduces enhancements to the EoAuthService class in the libs/eo/auth/data-access/auth.service.ts file, specifically focusing on the refreshToken method to include additional query parameters and improving the token refresh process.

Enhancements to refreshToken method:

  • Modified the refreshToken method to accept extraQueryParams as an optional parameter and pass it to signinSilent. (libs/eo/auth/data-access/auth.service.ts)
  • Updated the call to refreshToken to include specific query parameters (prompt, max_age, and t) for better control over the authentication flow. (libs/eo/auth/data-access/auth.service.ts)

References

  • #0000

Copy link

nx-cloud bot commented Oct 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6fbf62e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@frontend-specialisten frontend-specialisten merged commit c47ec1c into main Oct 23, 2024
30 checks passed
@frontend-specialisten frontend-specialisten deleted the fix/ett-b2c-cache-on-terms branch October 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants