fix: added context in item-template #886
Conversation
🦋 Changeset detectedLatest commit: dd58363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit dd58363): https://react-kitchen-sink-dev--pr886-885-context-in-item-4y5vbs4w.web.app (expires Thu, 21 Nov 2024 07:04:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
| const [evaluatedItems, setEvaluatedItems] = useState<CollapsibleTemplate[]>( | ||
| [], | ||
| ); | ||
| const [currentIndex, setCurrentIndex] = useState(-1); |
There was a problem hiding this comment.
Do not do this! Why did you no longer make this a component? This is going to be n renders of the entire Collapsible component instead of individual smaller renders.
Change this back to a component. Add a check in the parent Collapsible component so that it doesn't render anything until all the keys have been evaluated.
| template: CollapsibleItem; | ||
| setEvaluated: React.Dispatch<React.SetStateAction<CollapsibleTemplate[]>>; | ||
| }): null => { | ||
| const evaluatedData = useEvaluate({ ...template }, { context }); |
There was a problem hiding this comment.
This should only evaluate the key, otherwise you will create additional bindings for label and children attributes you don't need.
| prevEvaluated[currentIndex] = { key, label: header, children: content }; | ||
| return prevEvaluated; | ||
| }); | ||
| }, [currentIndex, evaluatedData, setEvaluated]); |
There was a problem hiding this comment.
This should only check for the key.
| ]); | ||
|
|
||
| setEvaluated((prev) => { | ||
| const prevEvaluated = [...prev]; |
| : EnsembleRuntime.render([unwrapWidget(label)]); | ||
|
|
||
| const content = EnsembleRuntime.render([ | ||
| unwrapWidget(children as string), |
There was a problem hiding this comment.
The children and label are the same across all the items right? This can be unwrapped once and passed in.
Describe your changes
Added context in item-template of collapsible widget
Screenshots [Optional]
After
Issue ticket number and link
Closes #885
Checklist before requesting a review
pnpm changeset add