Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-758 Adds new commit scope rule degradation functionality for synchronous and group commit. #6044

Open
wants to merge 42 commits into
base: DOCS-978-Full-Branch-5.6
Choose a base branch
from

Conversation

jpe442
Copy link
Contributor

@jpe442 jpe442 commented Sep 10, 2024

What Changed?

Adds new commit scope operation degradation functionality for synchronous commit and group commit. Affects both commit scope reference section and commit scopes feature section in PGD docs.

Tracked here in DOCS-758.

@jpe442 jpe442 changed the title Docs 758 Docs-758 Adds new commit scope rule degradation functionality for synchronous and group commit. Sep 10, 2024
@jpe442 jpe442 changed the title Docs-758 Adds new commit scope rule degradation functionality for synchronous and group commit. DOCS-758 Adds new commit scope rule degradation functionality for synchronous and group commit. Sep 10, 2024
@josh-heyer josh-heyer force-pushed the DOCS-978-Full-Branch-5.6 branch 2 times, most recently from 004687d to d9e248d Compare September 11, 2024 19:45
@jpe442 jpe442 marked this pull request as ready for review September 17, 2024 17:38
@jpe442 jpe442 requested a review from a team as a code owner September 17, 2024 17:38
@jpe442 jpe442 added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 17, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 17, 2024 20:48 Inactive
@jpe442 jpe442 requested a review from djw-m September 17, 2024 20:50
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 17, 2024 20:53 Inactive
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it is missing a "Degrade options" entry under commit scopes which explains what the DEGRADE ON clause does and which commands support it.

Also the reordering should be applies to the commit scope rules section... whatever order that will be...

@josh-heyer
Copy link
Contributor

⚠Rebased! Pull latest before continuing work.

@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 18, 2024 17:52 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 18, 2024 18:32 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 18, 2024 19:00 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 18, 2024 19:18 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 18, 2024 19:25 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 19, 2024 18:29 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 20, 2024 20:41 Inactive
@jpe442
Copy link
Contributor Author

jpe442 commented Sep 20, 2024

This feels like it is missing a "Degrade options" entry under commit scopes which explains what the DEGRADE ON clause does and which commands support it.

Also the reordering should be applies to the commit scope rules section... whatever order that will be...

Got it. Added Degrade options section and made reordering consistent throughout.

@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 20, 2024 20:52 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 24, 2024 19:11 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 24, 2024 20:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 10:03 Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 10:15 Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 10:33 Inactive
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some bits to tidy up but mostly there.

@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 14:29 Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-6044-docs-758 September 27, 2024 17:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants